This issue has been created
 
 
PlantUML Macro / cid:jira-generated-image-avatar-17bd1790-693e-4360-97ed-9db6166f0f29 PLANTUML-37 Open

Declare the URL format of the server parameter of the PlantUML macro

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-3d6b546e-336d-467b-ad6a-840effb0f2d6 Charpentier Lucas created this issue on 22/Oct/26 16:27
 
Summary: Declare the URL format of the server parameter of the PlantUML macro
Issue Type: cid:jira-generated-image-avatar-17bd1790-693e-4360-97ed-9db6166f0f29 Improvement
Affects Versions: 2.5
Assignee: Unassigned
Created: 22/Oct/26 16:27
Priority: cid:jira-generated-image-static-major-2733549f-a9fa-4c90-80ab-f52b0d3af265 Major
Reporter: Charpentier Lucas
Description:

The server parameter of the PlantUML macro takes a URL in a text field of the Edit Macro dialog, but declares no format, so the dialog accepts any text and the user only finds out at rendering.

The fix is done in PlantUMLMacroParameters.java:

  • Declare the URL format of the server parameter, for example with a @Pattern annotation. Whether the domain is trusted can still only be checked at rendering.

Depends on

  • XWIKI-25287, without which the Edit Macro dialog does not enforce the declared format and the value is only checked when the macro is rendered.

KOs covered

Macro Criterion Parameter Problem Depends on
plantuml C13 constraints server A URL with no declared format: "abc" is accepted and fails at rendering with "no protocol: abc". XWIKI-25287

Impact found on macro fluidity

This KO comes from the WYSIWYG usability audit of the macros, under the criterion C13 constraints of its usability criteria. The page of the macro, linked in the table, has the full notes and the steps to reproduce. Fixing it means declaring the format of one parameter of the macro.