There is 1 update.
 
 
Document Accordion Macro / cid:jira-generated-image-avatar-1ed26053-9caa-4f7b-aef6-b5124c4cef87 DOCACCORDI-16 Open

Excluding the hidden pages compares their hidden flag with a number

 
View issue   ยท   Add comment
 

1 update

 
cid:jira-generated-image-avatar-52d6e088-7424-4a62-8401-742ecf87c2b3 Changes by Thomas Mortagne on 17/Nov/26 15:35
 
Description: {{DocAccordionMacro}} excludes the hidden pages by comparing their hidden flag with a number:

{noformat}
AND doc.hidden=0
{noformat}

Since Hibernate 6, HQL checks the types of both sides of a comparison when the query is parsed, and rejects incompatible ones ({{SemanticException: Cannot compare left expression of type ... with right expression of type ...}}). XWiki is moving to Hibernate 7 (XWIKI-19708), where these queries will fail on every database. With Hibernate 5 the literal is copied as is in the SQL, so the queries rely on the database converting it implicitly, which not all databases do.

This probably already fails on PostgreSQL, where the hidden flag is stored in a {{boolean}} column which can't be compared with an integer.

Compare it with a boolean instead ({{doc.hidden = false}}). This works with all the databases and all the Hibernate versions.


PS: This post was co-written with Claude Code.