[xwiki-notifications] [xwiki/xwiki-platform] 3d15c1: [misc] Bulletproofing and improving tests to be ab...

Branch: refs/heads/stable-17.2.x Home: https://github.com/xwiki/xwiki-platform Commit: 3d15c1c892e1d2254e75b3f6f301156b8f6a9a43 https://github.com/xwiki/xwiki-platform/commit/3d15c1c892e1d2254e75b3f6f301… Author: Marius Dumitru Florea <marius(a)xwiki.com> Date: 2025-04-17 (Thu, 17 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-image/plugin.js M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/it/org/xwiki/ckeditor/test/ui/ImageIT.java M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/it/org/xwiki/ckeditor/test/ui/LinkIT.java M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/it/org/xwiki/ckeditor/test/ui/QuickActionsIT.java M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/it/org/xwiki/ckeditor/test/ui/TextAreaIT.java Log Message: ----------- [misc] Bulletproofing and improving tests to be able to run them multiple times on the same XWiki test instance. (cherry picked from commit b993bec565e8c59f3a7d620d8c57a85f64600440) (cherry picked from commit 42b7010b55eaa8916addc9fd7bf155465021b873) Commit: c094a45b43d0815af030a4c233805862142e5c93 https://github.com/xwiki/xwiki-platform/commit/c094a45b43d0815af030a4c23380… Author: Marius Dumitru Florea <marius(a)xwiki.com> Date: 2025-04-17 (Thu, 17 Apr 2025) Changed paths: R xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/resources/ImagePlugin/image.gif R xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/resources/ImagePlugin/otherImage.gif R xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/resources/ResourcePicker/image.gif A xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/resources/image.gif A xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/resources/otherImage.gif A xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/resources/text.txt Log Message: ----------- [misc] Reorganize the test resource files, because they are used by different test classes. (cherry picked from commit f3f4dd574ae8ba1dbb6b4d77f9bca28478bd9611) (cherry picked from commit 2eb372d608e6f03e90d36d95bc0e65a1d37c913f) Commit: 1aede42051367f06f8fa702450912ecbbfc4a02d https://github.com/xwiki/xwiki-platform/commit/1aede42051367f06f8fa70245091… Author: Marius Dumitru Florea <marius(a)xwiki.com> Date: 2025-04-17 (Thu, 17 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-selection/plugin.js M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-upload/plugin.js M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/it/org/xwiki/ckeditor/test/ui/ImageIT.java M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-webjar/src/main/webjar/config.js Log Message: ----------- XWIKI-23105: Pasting captioned images generates unexpected wiki syntax * Modify the paste filter to add the "image" class to the pasted figures, when they contain an image or linked image, in order for the editor to properly recognize them as captioned images. * Add integration test * Modify the upload plugin to support uploading captioned images that have been pasted (the caption is not stored in the image widget data so we can't save the data, destroy the image widget and recreate it after the image is uploaded; instead, we have to keep the image widget and create the upload image widget as a nested widget) * Fix the selection after a pasted image is recognized and upcasted as an image widget (make sure the caret is not hidden inside the read-only area of the image widget). (cherry picked from commit 334f273a4b7740af772f19bb58f4f970f64871f1) (cherry picked from commit 0e86f7daa937882a0d08bbe4984137f31a0326f9) Commit: f5936106b57aaa92b238f8232fbc457e99fe2982 https://github.com/xwiki/xwiki-platform/commit/f5936106b57aaa92b238f8232fbc… Author: Marius Dumitru Florea <marius(a)xwiki.com> Date: 2025-04-17 (Thu, 17 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-filter/plugin.js M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-upload/plugin.js M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/it/org/xwiki/ckeditor/test/ui/ImageIT.java M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-pageobjects/src/main/java/org/xwiki/ckeditor/test/po/RichTextAreaElement.java Log Message: ----------- XWIKI-23091: Moving an image in editor reuploads it as a new attachment, and sometimes corrupts it * Check the transfer type and don't propose to upload images copied from the same editor instance. * Fix: the CKEditor selection bookmarks are saved in wiki syntax when copying an image along with some text * Add integration tests (cherry picked from commit 77347fd478f9b242868b352dd7eba8b1cebe30e5) (cherry picked from commit 4a650ecc72ec8360717bf0058aca9c5bd75af932) Commit: cbcabec024f28c4d4309b863238b6abb4546c8e4 https://github.com/xwiki/xwiki-platform/commit/cbcabec024f28c4d4309b863238b… Author: Marius Dumitru Florea <marius(a)xwiki.com> Date: 2025-04-17 (Thu, 17 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-webjar/src/main/webjar/config.js Log Message: ----------- [misc] Replace var with const. (cherry picked from commit 91384f354c1ce030b046f710cb2889c5a6e178f9) (cherry picked from commit 3a054ba0bd0eb33e83b9f9e90ce67f3f814907fc) Compare: https://github.com/xwiki/xwiki-platform/compare/337043b45387...cbcabec024f2 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications