This issue has been created
There is 1 update.
 
 
XWiki Platform / cid:jira-generated-image-avatar-309c402c-36f6-4476-a83f-a3eccb7bf6cd XWIKI-25634 Open

WikiEditIT#allowForceSaveWhenCSRFIssue is flickering

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-f5758a94-8f30-4a62-b1c9-9b74be7aecbb Manuel Leduc created this issue on 02/Nov/26 15:00
 
Summary: WikiEditIT#allowForceSaveWhenCSRFIssue is flickering
Issue Type: cid:jira-generated-image-avatar-309c402c-36f6-4476-a83f-a3eccb7bf6cd Bug
Affects Versions: 18.4.7
Assignee: Unassigned
Components: Development Issues only
Created: 02/Nov/26 15:00
Labels: flickering
Priority: cid:jira-generated-image-static-major-069664fb-5c70-49ed-8217-56c97fa70cee Major
Reporter: Manuel Leduc
Description:

AllIT$NestedEditIT#allowForceSaveWhenCSRFIssue (class WikiEditIT in xwiki-platform-flamingo-skin-test-docker) failed once in the last 10 builds of the stable-18.4.x branch.

Where: https://ci.xwiki.org/job/XWiki%20Environment%20Tests/job/xwiki-platform/job/stable-18.4.x/172/ (MySQL latest, Tomcat 11-jdk25, Filesystem, Chrome). The other environment and the other recent builds passed.

Error:

org.openqa.selenium.WebDriverException:
unknown error: unhandled inspector error: {"code":-32000,"message":"Node with given id does not belong to the document"}
Command: [..., getElementAttribute {name=data-xwiki-page-ready, ...}]
	at org.xwiki.test.ui.XWikiWebDriver.waitUntilElementHasAttributeValue(XWikiWebDriver.java:484)
	at org.xwiki.test.ui.po.BaseElement.waitUntilPageIsReady(BaseElement.java:155)
	at org.xwiki.test.ui.po.BasePage.<init>(BasePage.java:145)
	at org.xwiki.test.ui.po.ViewPage.<init>(ViewPage.java:43)
	at org.xwiki.flamingo.test.docker.WikiEditIT.allowForceSaveWhenCSRFIssue(WikiEditIT.java:384)

Likely cause: after clickSaveAndView(false) and clickForceSaveCSRFButton(), the test immediately creates a ViewPage. Its constructor waits for data-xwiki-page-ready on the html element, but that element can still belong to the edit page that is being unloaded. Chrome then rejects the attribute read because the node is no longer part of the current document. The test needs to wait for the navigation to the view page to happen before building the ViewPage.

An older flicker of the same test was fixed in XWIKI-19905.

 
 

1 update

 
cid:jira-generated-image-avatar-f5758a94-8f30-4a62-b1c9-9b74be7aecbb Changes by Manuel Leduc on 02/Nov/26 15:00
 
Flickering Test: org.xwiki.flamingo.test.docker.AllIT$NestedEditIT#allowForceSaveWhenCSRFIssue