This issue has been created
 
 
XWiki Platform / cid:jira-generated-image-avatar-dc4695b7-2ea9-4863-8835-2e164cc02c3e XWIKI-25759 Open

Use CSS variables instead of color theme Velocity variables in the livetable stylesheet

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-c66d30f9-583d-408f-8070-ff61a15dc933 Charpentier Lucas created this issue on 13/Nov/26 16:04
 
Summary: Use CSS variables instead of color theme Velocity variables in the livetable stylesheet
Issue Type: cid:jira-generated-image-avatar-dc4695b7-2ea9-4863-8835-2e164cc02c3e Improvement
Affects Versions: 17.10.15
Assignee: Unassigned
Components: LiveTable
Created: 13/Nov/26 16:04
Priority: cid:jira-generated-image-static-major-a1e43084-c519-4b44-ad42-8e958223f6ac Major
Reporter: Charpentier Lucas
Description:

Part of the removal of the color theme Velocity variables ($theme, loaded with colorThemeInit.vm) from the stylesheets of XWiki Standard, following XWIKI-25649. The CSS variables introduced by XWIKI-22667 expose the same colors.

js/xwiki/table/livetable.css holds 50 usages of the color theme Velocity variables, the highest count of any stylesheet.

We should:

  • Replace each color theme Velocity variable of this stylesheet with its CSS variable.
  • Remove the loading of colorThemeInit.vm from it.

The stylesheet keeps its Velocity evaluation, since it also uses $xwiki.getSkinFile(...) for its icons.

The replacement follows the mapping Flamingo already uses in colorThemeMappingOutput.vm, for instance borderColor becomes -xwiki-border-color, textSecondaryColor becomes text-muted and highlightColor becomes -nav-link-hover-bg.

Visible change: none expected beyond small color differences. backgroundSecondaryColor becomes -xwiki-background-secondary-color, which follows the color theme, and a few CSS variables such as -text-muted have a value adjusted for contrast.