User picker in group editor is listing disabled user

Root cause

The group editor adds members using the standard user picker (#userPicker), which fetches its suggestions from the uorgsuggest.vm template. The XWQL query used by this template to search users didn't filter on the active property of XWiki.XWikiUsers, so disabled users were suggested. XWIKI-18766 fixed the same problem only for the "List of users" property displayer, which uses a different query (DefaultUsersQueryBuilder). Note that this affected all the user pickers (group editor, rights editor, Share Page, wiki owner / members, etc.), not only the group editor.

Fix

• uorgsuggest.vm now suggests only enabled users (user.active = 1), unless the includeInactiveUsers=true request parameter is passed. Loading the current selection is not affected, so a disabled user that is already selected (e.g. an existing group member) is still displayed properly.
• The user picker (JavaScript) has a new includeInactiveUsers setting, which defaults to the value of the data-include-inactive-users attribute, for the cases where disabled users should be suggested.
• The Live Data user filter (e.g. on the last author column) keeps suggesting disabled users, since documents may have been authored by users that were disabled later.
• Added a functional test checking that the group editor doesn't suggest disabled users.

Commits:

• master: e9889e2daa6
• stable-18.4.x: 52e0ed2607e
• stable-17.10.x: d366d22463c