Moving the parent from org.xwiki.contrib:parent-platform:14.10-7 to 17.10.0-2 (minimum XWiki 17.10, Java 17) is not enough on its own: the displayChanges macro silently displayed nothing on XWiki 17.10.
Root cause: Code/Change/DisplayChangesMacro read the list published by getChanges with
On XWiki 17.10 $xcontext.get('vcontext') no longer resolves the current Velocity context, so $changeItems was always null and the macro rendered nothing at all - not even its own "No changes!" fallback. This affected every change list in the application (release note pages, custom reports), not only the comparison filters; it was caught by ReleaseNotesIT#getChangesComparisonFiltersIncludeTheBoundaryVersion, which passes on 14.10 and failed on 17.10.
Fix: read the caller-named variable with #evaluate, the read counterpart of the #setVariable that getChanges already uses to publish it, and resolve $topSpace in the macro instead of relying on it leaking in from getChanges.
Verified with mvn clean install -Pquality,integration-tests,docker on XWiki 17.10.0: all 6 functional tests pass.
Vincent Massol on 29/Aug/26 11:32
Moving the parent from {{org.xwiki.contrib:parent\-platform:14.10\-7}} to {{17.10.0\-2}} \(minimum XWiki 17.10, Java 17\) is not enough on its own: the {{displayChanges}} macro silently displayed nothing on XWiki 17.10.
Root cause: {{Code/Change/DisplayChangesMacro}} read the list published by {{getChanges}} with
On XWiki 17.10 {{$xcontext.get\('vcontext'\)}} no longer resolves the current Velocity context, so {{$changeItems}} was always null and the macro rendered nothing at all \- not even its own "No changes\!" fallback. This affected every change list in the application \(release note pages, custom reports\), not only the comparison filters; it was caught by {{ReleaseNotesIT#getChangesComparisonFiltersIncludeTheBoundaryVersion}}, which passes on 14.10 and failed on 17.10.
Fix: read the caller\-named variable with {{#evaluate}}, the read counterpart of the {{#setVariable}} that {{getChanges}} already uses to publish it, and resolve {{$topSpace}} in the macro instead of relying on it leaking in from {{getChanges}}.
Verified with {{mvn clean install \-Pquality,integration\-tests,docker}} on XWiki 17.10.0: all 6 functional tests pass.
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6)
If image attachments aren't displayed, see this article.
