[xwiki-notifications] [xwiki/xwiki-commons] c02a05: XCOMMONS-2276 Upgrade to HtmlCleaner 2.25

Branch: refs/heads/feature-deploy-html-cleaner-upgrade Home: https://github.com/xwiki/xwiki-commons Commit: c02a05e37a8a226790c3c6cd66f7094ea0087a5c https://github.com/xwiki/xwiki-commons/commit/c02a05e37a8a226790c3c6cd66f70… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/pom.xml M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - update to the release done today - the "setRecognizeUnicodeChars" does no longer needed to be set to "false", but kept at the default value of "true" after https://sourceforge.net/p/htmlcleaner/bugs/221/ is fixed - also update the tests to reflect the current behavior; most of them are likely improvenents, but also add a few cases where this is not so clear - especially the test keeping entitiy encoded curly braces had to be disabled, as this no longer works that way Commit: a1cbd7a6adaa9758eb9fef33bad96493aa1bf76f https://github.com/xwiki/xwiki-commons/commit/a1cbd7a6adaa9758eb9fef33bad96… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/html/HTMLUtils.java Log Message: ----------- XCOMMONS-2265 HTML Encoded Line Feed character transformed in whitespace - remove the "clean double ampersand escape" workaround which is no longer necessary with HTMLCleaner 2.25 and even harmful in the use case where users want to have their amperand encoded, e.g. when displaying the encoded form in wiki pages Commit: 58a3cb5930a795bed37d9458590cc7d2bcb8d345 https://github.com/xwiki/xwiki-commons/commit/58a3cb5930a795bed37d9458590cc… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - put back the ecplicit call to "setRecognizeUnicodeChars(true)" and add a comment why Commit: 2b4a55caa9dd50b7294504f23f9904826db5e9de https://github.com/xwiki/xwiki-commons/commit/2b4a55caa9dd50b7294504f23f990… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - add more comments to tests to explain what they actually test and why - changed one test to use different test text to attribute values and text nodes - also fixed typos in test comments Commit: aba414f14ab5c8463927ed20dbf1ddb452c51f4a https://github.com/xwiki/xwiki-commons/commit/aba414f14ab5c8463927ed20dbf1d… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - removed one test that only documents the behavior of the html cleaner Commit: da179b63d48951831814465c86fcd52738a28592 https://github.com/xwiki/xwiki-commons/commit/da179b63d48951831814465c86fcd… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/pom.xml M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.29 * Upgrade to HtmlCleaner 2.29 and update tests Commit: f4e1887e879669e1e704fc59f2a8619df4df8405 https://github.com/xwiki/xwiki-commons/commit/f4e1887e879669e1e704fc59f2a86… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.29 * Clarify the test using @mflorea's comment information Commit: fc627229f0328f024d96da323eed23056cc6def7 https://github.com/xwiki/xwiki-commons/commit/fc627229f0328f024d96da323eed2… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.29 * Change remaining tests Commit: 1311b7c6b1964b193c34525b9a0e45cb2e1a1309 https://github.com/xwiki/xwiki-commons/commit/1311b7c6b1964b193c34525b9a0e4… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Remove unnecessary comment Commit: cf2c24aed9b436f88fa8f0cbb05a666a1a39cfa4 https://github.com/xwiki/xwiki-commons/commit/cf2c24aed9b436f88fa8f0cbb05a6… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java R xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/filter/ControlCharactersFilter.java M xwiki-commons-core/xwiki-commons-xml/src/main/resources/META-INF/components.txt M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/html/DefaultHTMLCleanerComponentList.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/html/HTMLUtilsTest.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Remove now unnecessary filter Commit: 839ca405e1bce58b5273fbcec0140ca3e8469c62 https://github.com/xwiki/xwiki-commons/commit/839ca405e1bce58b5273fbcec0140… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/XWikiHTML5TagProvider.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/HTML5HTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Remove now unnecessary workarounds and fix template test Co-authored-by: Michael Hamann <michael.hamann(a)xwiki.com> Commit: 14f9a6edaafa9e06b3cd9ff8a06b289e3c736a81 https://github.com/xwiki/xwiki-commons/commit/14f9a6edaafa9e06b3cd9ff8a06b2… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/HTML5HTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Revert experiment in test Commit: 3ca456d210e6107633c656088daf515aaaf5ac32 https://github.com/xwiki/xwiki-commons/commit/3ca456d210e6107633c656088daf5… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/XWikiHTML5TagProvider.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Update comments and minor style refactoring Compare: https://github.com/xwiki/xwiki-commons/compare/d0188b732676...3ca456d210e6 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications