This issue has been created
There are 2 updates.
 
 
Release Notes Application / cid:jira-generated-image-avatar-884d38a4-58c7-44da-9ef8-f997a41ec4f4 RN-133 Open

Match the REST change filters exactly and refuse the values that cannot be read

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-574477f6-7a73-4927-bd51-c76199795d0f Vincent Massol created this issue on 30/Sep/26 17:05
 
Summary: Match the REST change filters exactly and refuse the values that cannot be read
Issue Type: cid:jira-generated-image-avatar-884d38a4-58c7-44da-9ef8-f997a41ec4f4 Improvement
Assignee: Unassigned
Components: Application
Created: 30/Sep/26 17:05
Priority: cid:jira-generated-image-static-major-0e1ce7b9-42aa-455e-ab1a-6d42b8a0d23c Major
Reporter: Vincent Massol
Description:

The GET /wikis/{wikiName}/releasenotes/{product}/{version}/changes endpoint reads its filters loosely:

  • a mistyped value, e.g. audience=users, importance=huge, containsScreenshots=yes or limit=ten, is not refused: an audience or importance filter silently matches no change (the client gets an empty list it cannot tell from a real one), and the others silently fall back to their default;
  • a value is matched as a pattern (% and _ are wildcards) and may carry an operator prefix (>=high), which is the syntax of the getChanges wiki macro and not what the endpoint documents ("the audiences to keep, comma separated");
  • a parameter left empty (audience=) matches no change at all rather than filtering nothing.

The endpoint also reads each returned change a second time, checking the view right again for each one.

Proposed:

  • each listed value is matched exactly; an empty parameter filters nothing;
  • an unreadable value (unknown audience or importance, a screenshot filter other than true/false, a limit that is not a whole number of at least 1, a negative offset) is answered with 400 and a message naming the value;
  • a new ChangeManager#searchAndLoad(ChangeQuery, Predicate) (returning a LoadedChangeSearchResult) gives the changes with their pages in one call, the view right being checked once, by the search filter, before the result is paged (as done for RN-122).

The getChanges wiki macro and its syntax are unchanged.

 
 

2 updates

 
cid:jira-generated-image-avatar-574477f6-7a73-4927-bd51-c76199795d0f Changes by Vincent Massol on 30/Sep/26 17:05
 
Fix Version: 2.8
Assignee: Vincent Massol