This issue has been created
 
 
XWiki Platform / cid:jira-generated-image-avatar-04c2be5b-0bb0-4862-90d2-60eed3704091 XWIKI-25760 Open

Use CSS variables instead of color theme Velocity variables in the notification, print and job log styles

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-b9dfca0a-546f-4dfe-8742-b673269596c4 Charpentier Lucas created this issue on 13/Nov/26 16:04
 
Summary: Use CSS variables instead of color theme Velocity variables in the notification, print and job log styles
Issue Type: cid:jira-generated-image-avatar-04c2be5b-0bb0-4862-90d2-60eed3704091 Improvement
Affects Versions: 17.10.15
Assignee: Unassigned
Components: Flamingo Skin, Web - Templates & Resources
Created: 13/Nov/26 16:04
Priority: cid:jira-generated-image-static-major-306fc3e1-e3ee-4614-8441-e266c436f446 Major
Reporter: Charpentier Lucas
Description:

Part of the removal of the color theme Velocity variables ($theme, loaded with colorThemeInit.vm) from the stylesheets of XWiki Standard, following XWIKI-25649. The CSS variables introduced by XWIKI-22667 expose the same colors.

Three places use color theme Velocity variables in a context that needs more than a one to one replacement:

  • uicomponents/widgets/notification.css: the four notification colors are stored in a Velocity list and the rules are generated by a Velocity loop.
  • print.css of the Flamingo skin: textPrimaryColor is used in the print styles.
  • init.vm: highlightColor is used in the inline style of the job log.

We should replace these 6 usages with CSS variables, after checking for each that the CSS variables are available where the style applies, in particular for the print view and the PDF export.

Visible change: none expected beyond small color differences.