This issue has been created
There are 3 updates.
 
 
XWiki Platform / cid:jira-generated-image-avatar-8c3bd7eb-53ff-490e-b301-181936b2ba22 XWIKI-25649 Open

Use CSS variables instead of color theme Velocity variables in the Solr search stylesheet

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-e4e8d1e3-a32d-46a2-b814-c38bcac0a96c Charpentier Lucas created this issue on 04/Nov/26 13:51
 
Summary: Use CSS variables instead of color theme Velocity variables in the Solr search stylesheet
Issue Type: cid:jira-generated-image-avatar-8c3bd7eb-53ff-490e-b301-181936b2ba22 Improvement
Affects Versions: 17.10.14
Assignee: Unassigned
Components: Search - Solr
Created: 04/Nov/26 13:51
Priority: cid:jira-generated-image-static-major-673367cb-0f79-439a-a609-1ed17d978f8f Major
Reporter: Charpentier Lucas
Description:

The stylesheet of the Solr search page (the StyleSheetExtension object of Main.SolrSearch) is parsed with Velocity only to load colorThemeInit.vm and read 5 color theme variables: textSecondaryColor, highlightColor, titleColor, textColor and borderColor. The CSS variables introduced by XWIKI-22667 already expose the same values, so the stylesheet can use them instead and no longer needs Velocity parsing.

The search page looks the same with any color theme, and its stylesheet no longer has to be evaluated by Velocity.

 
 

3 updates

 
cid:jira-generated-image-avatar-e4e8d1e3-a32d-46a2-b814-c38bcac0a96c Changes by Charpentier Lucas on 04/Nov/26 13:51
 
Fix Version: 18.10.0-rc-1
Description: The stylesheet of the Solr search page (the {{StyleSheetExtension}} object of {{Main.SolrSearch}}) is parsed with Velocity only to load {{colorThemeInit.vm}} and read 5 color theme variables: {{textSecondaryColor}}, {{highlightColor}}, {{titleColor}}, {{textColor}} and {{borderColor}}. The CSS variables introduced by XWIKI-22667 already expose the same values, so the stylesheet can use them instead and no longer needs Velocity parsing.

The search page looks the same
with any color theme , and its stylesheet no longer has to be evaluated by Velocity. The only exception is with an old-style color theme that customizes {{textSecondaryColor}}: the muted texts of the search page then use the default muted text color of the skin, since that color theme variable is only mapped to {{--text-muted}} for the LESS-based color themes.
Assignee: Charpentier Lucas