This issue has been created
 
 
XWiki Platform / cid:jira-generated-image-avatar-0b18020f-a12a-4f12-95cf-c2362cfb3f8c XWIKI-25764 Open

Stop evaluating Velocity in the WAR stylesheets that no longer need it

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-9f2aa81f-b6fc-4479-bfbf-140f0693bd10 Charpentier Lucas created this issue on 13/Nov/26 16:04
 
Summary: Stop evaluating Velocity in the WAR stylesheets that no longer need it
Issue Type: cid:jira-generated-image-avatar-0b18020f-a12a-4f12-95cf-c2362cfb3f8c Improvement
Affects Versions: 17.10.15
Assignee: Unassigned
Components: Web - Templates & Resources
Created: 13/Nov/26 16:04
Priority: cid:jira-generated-image-static-major-36fa61e3-d8ca-4870-abc5-62e52a26dd7d Major
Reporter: Charpentier Lucas
Description:

Once the color theme Velocity variables are removed from them, 17 stylesheets of the WAR contain no Velocity code anymore. They are still requested with Velocity evaluation, through $xwiki.ssfx.use('...', true) or the forceSkinAction parameter, sometimes with a colorTheme parameter, in about 30 places of the templates and wiki pages.

The stylesheets are: diff.css, wizard.css, usersandgroups.css, tags.css, history.css, comments.css, fullScreen.css, job.css, modalPopup.css, picker.css, information.css, livevalidation.css, resubmit.css, actionButtons.css, compactLocationPicker.css, locationPicker.css and select.css.

For a performance improvement, we should request these stylesheets without Velocity evaluation, so that they are served as static resources.

Visible change: none.