This issue has been created
There is 1 update.
 
 
Security Advisory Application / cid:jira-generated-image-avatar-72f564ea-b5df-4443-ab05-e210c22050e0 SPAPP-43 Open

GitHub users registered by the advisory import are hidden from the "GitHub users mapping" administration table

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-68bad348-c801-467f-868f-9952ce5d5d4b Simon Urli created this issue on 12/Nov/26 11:56
 
Summary: GitHub users registered by the advisory import are hidden from the "GitHub users mapping" administration table
Issue Type: cid:jira-generated-image-avatar-72f564ea-b5df-4443-ab05-e210c22050e0 Bug
Affects Versions: 2.3.0
Assignee: Unassigned
Created: 12/Nov/26 11:56
Priority: cid:jira-generated-image-static-major-8712d852-218e-44d6-9883-052396925fd5 Major
Reporter: Simon Urli
Description:

The "GitHub users mapping" table of the Security Advisory administration ("Administer Wiki" > "Other" > "Security Advisory") is empty by default, even when imported advisories involve GitHub users. An administrator therefore never sees the GitHub users to map or ignore, unless they clear the "Ignored" filter by hand.

Steps to reproduce

  1. Import advisories from GitHub, so that some GitHub users are registered (one hidden page per user under SecurityAdvisoryApplication.Code.ExternalUsers).
  2. Open "Administer Wiki" > "Other" > "Security Advisory" and look at the "GitHub users mapping" table.

Expected: the GitHub users that are not ignored are listed.
Actual: "Entries 0 - 0 out of 0". Clearing the "Ignored" filter lists all of them, with an empty "Ignored" value.

Cause

The Live Data is declared with filters="archived=0", but ExternalUserMappingStore#register (and save in general) only sets hint, externalId and login on the ExternalUserMappingClass object: archived is never set, so it has no stored value and the filter excludes it. Only a user ignored then un-ignored gets archived=0.

Either set archived to 0 when registering the external user (and migrate the existing pages), or make the filter match an empty value too.

Introduced by SPAPP-25.

 
 

1 update

 
cid:jira-generated-image-avatar-68bad348-c801-467f-868f-9952ce5d5d4b Changes by Simon Urli on 12/Nov/26 11:56
 
Attachment: github-users-mapping-empty-by-default.png