There is 1 comment.
 
 
Confluence / cid:jira-generated-image-avatar-faea6d96-0797-4a1d-882d-8bb2a230d226 CONFLUENCE-243 Open

MacroConverter expects a ConfluenceConverterListener but declares a Listener

 
View issue   ยท   Add comment
 

1 comment

 
cid:jira-generated-image-avatar-618f3e8f-3962-4ee2-bc3f-24418d3b4e9a Michael Hamann on 29/May/24 12:18
 

It might seem that a simple fix is to just pass the wrapped listener directly to the MacroConverter in the ConfluenceConverterListener, but this would most likely break code like https://github.com/xwikisas/application-task/blob/1a9bfdcb2e2b7dc5d368e7efbf3cd46df9e42189/application-task-default/src/main/java/com/xwiki/task/internal/TaskListMacroConverter.java#L65, as if, e.g., the parsed content there contains links, they wouldn't be converted anymore.