26 May
2025
26 May
'25
5:21 p.m.
Branch: refs/heads/stable-16.10.x
Home: https://github.com/xwiki/xwiki-platform
Commit: bd0b201f08a79886016d1bedff189d807d485090
https://github.com/xwiki/xwiki-platform/commit/bd0b201f08a79886016d1bedff18…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-05-26 (Mon, 26 May 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-macro/src/main/java/org/xwiki/icon/macro/internal/DisplayIconMacro.java
M
xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-macro/src/main/java/org/xwiki/livedata/internal/macro/LiveDataMacro.java
M
xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-macro/src/test/java/org/xwiki/livedata/internal/macro/LiveDataMacroTest.java
M
xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-macro/src/main/java/org/xwiki/localization/macro/internal/TranslationMacro.java
M
xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-macro/src/main/java/org/xwiki/rendering/internal/macro/office/OfficeMacro.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-code/src/main/java/org/xwiki/rendering/internal/macro/code/CodeMacro.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-gallery/src/main/java/org/xwiki/rendering/internal/macro/gallery/GalleryMacro.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/DefaultWikiMacro.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/WikiMacroClassDocumentInitializer.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/WikiMacroConstants.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/WikiMacroContentMacro.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/WikiMacroParameterMacro.java
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/resources/ApplicationResources.properties
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/test/java/org/xwiki/rendering/wikimacro/internal/DefaultWikiMacroFactoryTest.java
Log Message:
-----------
XRENDERING-778: Rendering a page with thousands of macros is slow (#4020)
* Introduce the concept of isolated execution in wiki macros.
* Mark many macros as isolated.
(cherry picked from commit 64fc5f3a0cd2d35f0e464a4923949123bca8e70f)
Commit: b442cf9e06d57de941bca0d25b3dbbd1a718a18d
https://github.com/xwiki/xwiki-platform/commit/b442cf9e06d57de941bca0d25b3d…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-05-26 (Mon, 26 May 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-page/src/main/java/org/xwiki/test/page/PageComponentList.java
Log Message:
-----------
XRENDERING-778: Rendering a page with thousands of macros is slow
* Fix page tests.
(cherry picked from commit 9d64bf787fdffcb12df11e387295076c17fd2940)
Commit: 30cd90a820c1fb3941148ad87eced416c1f2fa2a
https://github.com/xwiki/xwiki-platform/commit/30cd90a820c1fb3941148ad87ece…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-05-26 (Mon, 26 May 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/WikiMacroConstants.java
Log Message:
-----------
[Misc] Document backport of isolated macro execution feature
(cherry picked from commit e3aee497d6729a40367055e30296ec450782c77a)
Commit: 574393e78e76a648ce791699143de755c99cc252
https://github.com/xwiki/xwiki-platform/commit/574393e78e76a648ce791699143d…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-05-26 (Mon, 26 May 2025)
Changed paths:
A
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/main/java/org/xwiki/test/SecurityCachePerformanceTestScriptService.java
M
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/main/resources/META-INF/components.txt
M
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/AllIT.java
A
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/SecurityCacheStressIT.java
M
xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCache.java
M
xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheLoader.java
M
xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/SecurityCache.java
M
xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheLoaderTest.java
M
xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheTest.java
Log Message:
-----------
XWIKI-22979: Access to pages is slow under high load on the security cache (#3992)
* Remove the read lock of the security cache to avoid blocking read
access during cache writes.
* Switch from a ReadWriteLock to a simple write lock as ReadWriteLocks
might be slow, and we don't really need it anymore.
* Remove the useless check of the internal entries for security access
entries to avoid needlessly acquiring the write lock.
* Improve the concurrency behavior of upgrading entries to user entries
to ensure that removing the read lock is safe.
* Replace the invalidation lock used to prevent loading outdated data by
an invalidation counter. This avoids holding any locks in the security
cache while a document is potentially loaded from the database. Before
that, it could happen that while a remove operation is waiting on the
lock, a database load is executed under the invalidation read lock.
That would block both the invalidation and all further cache loads as
the invalidation read lock cannot be obtained anymore as soon as a
thread is waiting for the invalidation write lock.
* Update the security cache loader and the affected tests.
* Make the write lock in the security cache unfair for increased
performance.
* Add a stress test for the security cache.
(cherry picked from commit 05adae51bde4ca0696a24e8e2a9ca0c5ab693af2)
Commit: f298cc99a5200278b9ad5389383ca41255de4bb8
https://github.com/xwiki/xwiki-platform/commit/f298cc99a5200278b9ad5389383c…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-05-26 (Mon, 26 May 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiCacheStore.java
M
xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/XWikiCacheStoreTest.java
M
xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/test/MockitoOldcore.java
Log Message:
-----------
XWIKI-23055: The document cache may not be properly invalidated in case of concurrent
loads (#4017)
* Use CacheLoader to synchronize cache loads.
* Add tests for the scenario in the issue and some more scenarios.
* Mock com.xpn.xwiki.store.XWikiStoreInterface.saveXWikiDoc(
com.xpn.xwiki.doc.XWikiDocument, com.xpn.xwiki.XWikiContext, boolean) in
MockitoOldcore to make testing of the cache store easier.
* Reduce duplication in invalidation by always performing null checks
and never storing anything as storing "false" after a document is
deleted might be dangerous.
(cherry picked from commit 9fff30a007dc2d6bd8a3f4fb557324d138c9ee33)
Commit: 5415615ba52b8b6a347404366a64deaa60cb1941
https://github.com/xwiki/xwiki-platform/commit/5415615ba52b8b6a347404366a64…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-05-26 (Mon, 26 May 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/SecurityCache.java
Log Message:
-----------
[Misc] Document backport of invalidation counter in SecurityCache
(cherry picked from commit 8bce28408da6b23f5bd8ad62191d029766fde9fe)
Compare: https://github.com/xwiki/xwiki-platform/compare/68b71b0f68dc...5415615ba52b
To unsubscribe from these emails, change your notification settings at
https://github.com/xwiki/xwiki-platform/settings/notifications