This issue has been created
There is 1 update.
 
 
Confluence / cid:jira-generated-image-avatar-1b74de20-e290-487c-80ec-1abf55ee2610 CONFLUENCE-467 Open

Conversion throws when an inline comment marker is in a list in a blockquote

 
View issue   ·   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-9595c3d0-7cd3-4ac2-8983-2cd72696612e Raphaël Jakse created this issue on 22/May/25 09:29
 
Summary: Conversion throws when an inline comment marker is in a list in a blockquote
Issue Type: cid:jira-generated-image-avatar-1b74de20-e290-487c-80ec-1abf55ee2610 Bug
Affects Versions: 9.86.0
Assignee: Unassigned
Components: Syntax - XHTML
Created: 22/May/25 09:29
Priority: cid:jira-generated-image-static-major-23601a64-7d09-44d4-b00d-7154c69e5a3d Major
Reporter: Raphaël Jakse
Description:

The following makes fails to convert:

<blockquote>
  <ol>
    <li><ac:inline-comment-marker ac:ref="31c632a6-86ec-4a76-9cad-b39db413b79c">hello</ac:inline-comment-marker>
    </li>
  </ol>
</blockquote>

When onWord("hello") is produced, a beginFormat(NONE) is automatically inserted because of the ac:ref parameter of the ac:inline-comment-marker tag. No corresponding endFormat() is produced at the end of the list item and this seems to confuse the renderer. This doesn't happen when no blockquote surrounds the list, for some reason. While debugging, I seem to have seen that the beginFormat happens because closeFormat is called, but ultimately no closeFormat is produced. This doesn't affect the regular XWiki (X)HTML syntax because we have a complex list handling that bypasses wikimodel and the regular XHTML syntax doesn't, and possibly because the regular XHTML syntax doesn't have a handler for ac:inline-comment-marker.

Note that something similar happens when the ac:inline-comment-marker tag is replaced with a strong tag with no parameter but this time, the conversion doesn't fail.

inserting a corresponding endFormat when there's no matching one at the end of the list item seems to make things work.

Note: the xwiki syntax doesn't support lists in blockquotes (see https://forum.xwiki.org/t/handle-nested-block-quotes-in-xwiki-syntax-or-in-a-macro/16991), but that's a separate issue.

 
 

1 update

 
cid:jira-generated-image-avatar-9595c3d0-7cd3-4ac2-8983-2cd72696612e Changes by Raphaël Jakse on 22/May/25 09:30
 
Assignee: Raphaël Jakse