There are 2 comments.
 
 
XWiki Platform / cid:jira-generated-image-avatar-f9736d90-85c6-4fba-a8e9-4202a51eec24 XWIKI-24485 Open

The Icon theme REST API doesn't indicate the skin extensions required by the returned icons

 
View issue   ยท   Add comment
 

2 comments

 
cid:jira-generated-image-avatar-3e1a5250-0e7c-494f-8207-6ad5a0f0a805 Marius Dumitru Florea on 15/Jun/26 14:01
 
We need to use the {{RequiredSkinExtensionsRecorder}} and {{IconRenderer#use() , but this mean changing the signature of the REST API to return \{{Response }} instead of \{{Icons}} in order to be able to set the HTTP header . It's not an actual API breakage because REST API clients shouldn't notice any difference (besides the extra HTTP header).}}
 
cid:jira-generated-image-avatar-3e1a5250-0e7c-494f-8207-6ad5a0f0a805 Marius Dumitru Florea on 15/Jun/26 14:01
 
We need to use the {{RequiredSkinExtensionsRecorder}} and {{IconRenderer#use() }} , but this mean changing the signature of the REST API to return \ {{Response}} instead of \ {{Icons}} in order to be able to set the HTTP header. It's not an actual API breakage because REST API clients shouldn't notice any difference (besides the extra HTTP header). }}