There are 8 updates, 1 comment.
 
 
XWiki Platform / cid:jira-generated-image-avatar-fee8ed77-761c-4e92-b3e2-008bf1082977 XWIKI-23846 Closed

Editor initialization causes duplicated fullscreen button in wiki editor

 
View issue   ยท   Add comment
 

8 updates

 
cid:jira-generated-image-avatar-204a49a9-3b6c-466b-9e6c-3d1f33596d38 Changes by Simon Urli on 15/Jan/26 10:41
 
Fix Version: 18.0.0-rc-1
Fix Version: 17.4.9
Fix Version: 16.10.17
Documentation in Release Notes: N/A
Documentation: N/A
Resolution: Fixed
Status: Open Closed
Labels: bugfixingday regression usability
 
 

1 comment

 
cid:jira-generated-image-avatar-204a49a9-3b6c-466b-9e6c-3d1f33596d38 Simon Urli on 15/Jan/26 10:41
 

So it's indeed a small regression caused by XWIKI-23626 as I refactored the code of fullscreen.js to also react on xwiki:dom:updated event since the toolbar is now supported also for xobjects and apparently I forgot to check a condition to ensure the fullscreen wouldn't be created twice. The fix should be easy though.