This issue has been created
There are 2 updates, 5 comments.
 
 
Prism.js Macro / cid:jira-generated-image-avatar-bab9f70c-1f13-436f-9113-18d7a3c37bbc XPRISMJS-10 Open

Also override CodeMacro#prepare() to improve performances further
 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-49de6039-3909-494f-8d6b-234567624438 Vincent Massol created this issue on 29/Oct/25 20:10
 
Summary: Also override CodeMacro#prepare() to improve performances further
Issue Type: cid:jira-generated-image-avatar-bab9f70c-1f13-436f-9113-18d7a3c37bbc Improvement
Affects Versions: 1.2.2
Assignee: Unassigned
Created: 29/Oct/25 20:10
Priority: cid:jira-generated-image-static-major-0bf2ab98-556e-4f33-911a-4d3c5df42d0e Major
Reporter: Vincent Massol
Description:

See https://github.com/xwiki-contrib/prismjs/commit/92087ec67e94ebf15bf422e1ca5fc62f2455e6e5#r169122822
 
 

2 updates

 
cid:jira-generated-image-avatar-49de6039-3909-494f-8d6b-234567624438 Changes by Vincent Massol on 29/Oct/25 20:10
 
Fix Version: 1.3
Assignee: Vincent Massol
 
 

5 comments

 
cid:jira-generated-image-avatar-49de6039-3909-494f-8d6b-234567624438 Vincent Massol on 29/Oct/25 20:15
 

Note: it's not so easy since the prepare was introduced in XWiki 17.2.0-rc-1, 16.10.6 (XWIKI-23011) while the macro currently depends on 16.10.0.
 
cid:jira-generated-image-avatar-49de6039-3909-494f-8d6b-234567624438 Vincent Massol on 29/Oct/25 20:17
 

The simplest would be to update the minimal POM to 16.10.6. BTW we have an issue in minimal POMs since that would mean that if the macro is installed on 17.1..0 (for ex), it will fail... So I guess we could upgrade the minimal POM to 17.2.0 but that's a relatively big change.
 
cid:jira-generated-image-avatar-49de6039-3909-494f-8d6b-234567624438 Vincent Massol on 29/Oct/25 20:18
 
The simplest would be to update the minimal POM to 16.10.6. BTW we have an issue in minimal POMs since that would mean that if the macro is installed on 17.1..0 (for ex), it will fail... So I guess we could upgrade the minimal POM to 17.2.0 but that's a relatively big change.

Any opinion [~tmortagne]?
 
cid:jira-generated-image-avatar-49de6039-3909-494f-8d6b-234567624438 Vincent Massol on 29/Oct/25 20:18
 
The simplest would be to update the minimal POM to 16.10.6. BTW we have an issue in minimal POMs since that would mean that if the macro is installed on 17.1..0 (for ex), it will fail... So I guess we could upgrade the minimal POM to 17.2.0 but that's a relatively big change.

Any opinion [~tmortagne]?

PS: Note that xwiki.org is on 17.4.4 so that's not a problem for xwiki.org.
 
cid:jira-generated-image-avatar-49de6039-3909-494f-8d6b-234567624438 Vincent Massol on 29/Oct/25 20:19
 
The simplest would be to update the minimal POM to 16.10.6. BTW we have an issue in minimal POMs since that would mean that if the macro is installed on 17.1..0 (for ex), it will fail... So I guess we could upgrade the minimal POM to 17.2.0 but that's a relatively big change.

 Any opinion [~tmortagne]?

 PS: Note that xwiki.org is on 17.4.4 so that's not a problem for xwiki.org.
 
 
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6) Atlassian logo
If image attachments aren't displayed, see this article.