[xwiki-notifications] [xwiki/xwiki-platform] 0a86a7: XWIKI-17510: The reset password functionality is n...

Branch: refs/heads/XWIKI-17510 Home: https://github.com/xwiki/xwiki-platform Commit: 0a86a74a8350f739ae5876361c671b182bc975f8 https://github.com/xwiki/xwiki-platform/commit/0a86a74a8350f739ae5876361c67… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2023-11-08 (Wed, 08 Nov 2023) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-ui/src/main/resources/XWiki/Registration.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/RegisterAction.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-api/src/main/java/org/xwiki/security/authentication/RegistrationConfiguration.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/DefaultRegistrationConfiguration.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/RegistrationConfigurationSource.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-script/src/main/java/org/xwiki/security/authentication/script/RegistrationScriptService.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-script/src/main/resources/META-INF/components.txt M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/passwd.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/register_macros.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/resetpasswordinline.vm Log Message: ----------- XWIKI-17510: The reset password functionality is not affected by password strength rules * Provide new APIs for accessing RegistrationConfiguration * Define a script service to access this API from scripts * Rewrite velocity macro #loadConfig to exploit this new API and to remove unused arguments * Use the new API also in oldcore where needed WIP: Coverage is not yet met. And missing execution of integration tests to validate everything. Also some properties from RegistrationConfig have not been exposed yet. This probably need to be also done. Commit: f3b4e4e19fb1fa4d2f6a7c61278dfdeb29b4b581 https://github.com/xwiki/xwiki-platform/commit/f3b4e4e19fb1fa4d2f6a7c61278d… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2023-11-08 (Wed, 08 Nov 2023) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-api/src/main/java/org/xwiki/security/authentication/RegistrationConfiguration.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-api/src/main/java/org/xwiki/security/authentication/ResetPasswordManager.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/DefaultResetPasswordManager.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/RegistrationConfigurationSource.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DefaultRegistrationConfigurationTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DefaultResetPasswordManagerTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-script/src/main/java/org/xwiki/security/authentication/script/RegistrationScriptService.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-script/src/test/java/org/xwiki/security/authentication/script/RegistrationScriptServiceTest.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/passwd.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/register_macros.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/resetpasswordinline.vm Log Message: ----------- XWIKI-17510: The reset password functionality is not affected by password strength rules * Provide new API in ResetPasswordManager to allow ensuring a password is compliant with the registration rules on backend * Check that the password is ok when creating a new user * Fix bugs and perform improvments on templates Commit: 07300d4c063a79b4280f8f494ddd47749a4e5703 https://github.com/xwiki/xwiki-platform/commit/07300d4c063a79b4280f8f494ddd… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2023-11-08 (Wed, 08 Nov 2023) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-ui/src/main/resources/XWiki/Registration.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/resources/ApplicationResources.properties M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/registerinline.vm Log Message: ----------- XWIKI-17510: The reset password functionality is not affected by password strength rules * Add better translation message whenever a rule is not respected Commit: 850e0730133c283af2b7332851234db73634fd4e https://github.com/xwiki/xwiki-platform/commit/850e0730133c283af2b733285123… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2023-11-08 (Wed, 08 Nov 2023) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-ui/src/main/resources/XWiki/Registration.xml M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-api/src/main/java/org/xwiki/security/authentication/ResetPasswordManager.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DefaultResetPasswordManagerTest.java Log Message: ----------- XWIKI-17510: The reset password functionality is not affected by password strength rules Improvments after @manuelleduc review * Fix typo in Registration * Use a default method for the new API to avoid breakage * Improve unit tests to use a parameterized test Commit: d5fba4f3f0657a10104c641599fc24578cd27118 https://github.com/xwiki/xwiki-platform/commit/d5fba4f3f0657a10104c641599fc… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2023-11-09 (Thu, 09 Nov 2023) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/src/test/it/org/xwiki/administration/test/ui/RegisterIT.java M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-ui/src/main/resources/XWiki/Registration.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/RegisterAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources.properties M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/AbstractRegistrationPage.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/registerinline.vm Log Message: ----------- XWIKI-17510: The reset password functionality is not affected by password strength rules Start working on the integration test to validate XWIKI-17510 and more globally that the register page was working in a close wiki. When doing so I discovered I actually also needed XWIKI-21444 to be fixed and in particular to have live validation. So I refactored registerinline to be able to use livevalidation and to also handle properly captcha. Still a WIP, currently RegisterIT#registerWikiSyntaxName is failing, still need to investigate why as it seems to work when testing manually. Compare: https://github.com/xwiki/xwiki-platform/compare/e6f688983bfd...d5fba4f3f065