|
| Summary: |
Annotations tab: Several regressions in the author line no longer matches annotation display after the Comments tab UI rework |
| Description: |
XWIKI-23740 renamed reworked the annotation display : it renamed the display classes (.annotationAvatar → .annotation-bubble-avatar, same for header and content) and , switched the avatar from #mediumUserAvatar to #smallUserAvatar, but and scoped the replacement rules to .annotation-box .annotation. Everything that displays an annotation outside the bubble was left behind. The Annotations tab is only shown when showannotations is enabled in the administration, which is why most of this was not updated missed .
h3. Annotations tab layout
The #allAnnotations .annotationAvatar / .annotationHeader / .annotationContent / .annotationTitle rules in AnnotationCode.Style are now dead, and the replacement rules are scoped to .annotation-box .annotation, which the tab markup has no ancestor of. In the tab the avatar therefore gets no layout at all and renders as a bare 30px block image above the author name, while the Comments tab shows a 50px avatar in a 60px left gutter.
The same applies to the rules styling the toolbox buttons themselves, and the annotation body rules for definition lists and blockquotes still target .annotationContent, which nothing emits anymore, so the bubble lost that spacing too.
h3. Missing actions (checked at xwiki-platform-18.8.0-rc-1)
* The Annotations tab and the annotation edit form no longer show the Edit / Delete / Validate buttons: #displayAnnotationToolboxFromReference now renders only in view mode (AnnotationCode.Macros). 18.7.0 had them.
* The bubble has no Validate button anymore for annotations stored as comments (XWiki.XWikiComments), it is only shown when showannotations kept for custom annotation classes.
h3. Date format
The fallback date format dd/MM/yyyy hh:mm is enabled 12-hour without AM/PM, so 15:43 is displayed as 03:43.
h3. Older problems in the administration same code
These predate XWIKI-23740 (git log -S points at a 2011 module rename) and are not regressions , which is why but they are in the same rules and the tab layout above made the first one span the full width of the text:
* The UPDATED state paints notesmallorange.png, a 10x10 image, as a background-image with no background-repeat, so it was missed tiles across the whole comment text .
* The ALTERED equivalent never applied at all: #allAnnotations .ALTERED annotationText is missing the dot before annotationText.
* .originalAnnotatedText has no rule, so the original selection of an UPDATED annotation is displayed exactly like the live one.
* Both state rules are scoped under #allAnnotations, so the bubble shows no state at all. |
|
