There is 1 comment.
 
 
Release Notes Application / cid:jira-generated-image-avatar-a98c2730-e181-487a-990d-eaf5d25999be RN-111 Open

The application pages do not declare the rights they require

 
View issue   ·   Add comment
 

1 comment

 
cid:jira-generated-image-avatar-d5e3b001-ea8a-4f4d-8a5e-b13906d43ef5 Vincent Massol on 07/Sep/26 15:31
 

Correcting my previous comment: PR 51 is not ready — CI is red and the branch is broken. It has been converted to draft.

Jenkins build 1 fails with 6 of the 10 ReleaseNotesIT tests failing (the 119 unit/PageTests pass). I had not run the Docker ITs, and mvn clean install -Pquality does not run them, so my "no behaviour change" claim was wrong for a fresh install.

The wiki macros no longer register: The [releasenotechanges] macro is not in the list of registered macros, Unknown macro: getChanges, Unknown macro: displayChanges. All five XWiki.WikiMacroClass pages have visibility = Current Wiki, so registering them takes wiki-admin-level right for the macro document's author, and declaring script caps the author below that.

The required-rights analyzer reported script for all five — it analyses what the macro body needs, not what registering a wiki-scoped macro needs. It does ask for wiki_admin on the wiki-scoped UIExtensionClass and TranslationDocumentClass pages, so the blind spot is specific to WikiMacroClass. The fix is to raise those five to wiki_admin and re-run the ITs.

Note for the record: this was invisible on a local wiki that already had the macros registered from an earlier install. Only a fresh install shows it.