Missing images in the rendered diff

View issue · Add comment

Issue created

Simon Urli created this issue on 25/Jun/25 15:41

Summary:	Missing images in the rendered diff
Issue Type:	Bug
Affects Versions:	1.16
Assignee:	Unassigned
Created:	25/Jun/25 15:41
Priority:	Major
Reporter:	Simon Urli
Description:	Images seems to be missing in the rendered diff view in xwiki.org e.g. in https://dev.xwiki.org/xwiki/bin/view/ChangeRequest/Data/Customizing-the-XWiki-UI-34790b52-7c7d-49dc-b8e0-353a27ba96dc/

1 update

Changes by Simon Urli on 25/Jun/25 15:41

Assignee:

Simon Urli

1 comment

Simon Urli on 25/Jun/25 15:43

This issue is actually related to a cluster setup. Currently the diff renderer works this way with CR:

1. we push in the temporary attachment session all attachments coming from the modified doc (the CR)
2. we ask to get the rendered diff HTML
3. when doing so, we have a filter which checks the image URLs and tries to download them to put data URI instead of their download url
4. we clean up the temporary attachment session for added attachments
5. we return the Html diff result

normally at step 3 the DownloadAction called check the temporary attachment session
but in case of cluster, it might be the DownloadAction of the other node, which doesn't have the same temporary attachment session...
The problem is then more generic than just CR as it might happen also for other UC in XS.

This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6)

If image attachments aren't displayed, see this article.