[xwiki/xwiki-platform] 8e9d7d: [Misc] Fix various SonarQube issues
Branch: refs/heads/claude/clever-feynman-06p27o Home: https://github.com/xwiki/xwiki-platform Commit: 8e9d7df795c6aaa666e7ea7199dece970445db3a https://github.com/xwiki/xwiki-platform/commit/8e9d7df795c6aaa666e7ea7199dec... Author: Vincent Massol <[email protected]> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-reference/src/test/java/org/xwiki/annotation/reference/internal/AbstractTypedStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/main/java/org/xwiki/captcha/internal/JCaptchaCaptcha.java M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/test/java/org/xwiki/eventstream/internal/DefaultUntypedRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/legacy/LegacyEventDispatcher.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/org/xwiki/legacy/internal/oldcore/notification/LegacyNotificationDispatcher.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/ActionExecutionEventConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/PackageException.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/template/InternalTemplateManagerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/XWikiRepositoryModel.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/ModelFactory.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/resources/pages/PageTagsResourceImpl.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/classes/ClassPropertyValuesResourceImplTest.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S3599 replace double-brace initialization with a plain collection copy * java:S4838 iterate with the collection's own element type * java:S9016 extract nested mock creations into local variables * java:S5778 hoist the non-throwing calls out of the assertThrows lambdas * java:S1121 extract the assignments out of the substring() arguments * java:S1710 drop the @Extensions wrapper around a single annotation * java:S2676 swap the operands instead of negating compareTo() * java:S1171 make the initializer static, it only fills a static field * java:S115 rename two private test constants to CONSTANT_CASE * java:S1165 make the exception field final, and rename it so that adding "final" does not just trade the issue for a java:S115 on the same line Co-Authored-By: Vincent Massol <[email protected]> Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications