Branch: refs/heads/misc-logging-oldcore-finish Home: https://github.com/xwiki/xwiki-platform Commit: 4dba0897f4ed12b547109af27f07416273a341cc https://github.com/xwiki/xwiki-platform/commit/4dba0897f4ed12b547109af27f074... Author: Vincent Massol <[email protected]> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorData.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java Log Message: ----------- [Misc] Restore the isDebugEnabled() guards around the debug blocks that do work Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLog... An isDebugEnabled() guard is redundant in front of a single parameterized log statement, but not in front of a block that computes something. Two such blocks lost their guard when the parameterized signatures were introduced: * MonitorData#log() iterates over all the timer summaries, so the iteration was paid on every call even with the debug level disabled. Also use a for-each loop instead of an explicit Iterator. * XWikiAuthServiceImpl#checkPassword() computes the elapsed validation time. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications