Branch: refs/heads/claude/cool-tesla-jwqn4a Home: https://github.com/xwiki/xwiki-dev-llm Commit: bd8d4ff98b0f9b01ee81819ad8ac3230bb4660e5 https://github.com/xwiki/xwiki-dev-llm/commit/bd8d4ff98b0f9b01ee81819ad8ac32... Author: Vincent Massol <[email protected]> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/simplification-rules.md Log Message: ----------- [Misc] Correct the S3457 toString() guidance and point it at the logging convention The first version of this PR said the "No need to call toString()" shape was a free deletion. That is wrong for a logging call and contradicts conventions/logging.md: Message.formattedMessage is transient, so a captured LogEvent keeps the raw Object[] and the job-status log XStream-serializes each argument, meaning an explicit toString() is often load-bearing. Document String.valueOf(x) as the form that clears the rule while keeping the eager snapshot, and cross-reference logging.md. Also add a universal drop condition for the more general trap behind it: a rationale is not always a comment, sometimes it is a commit message, so check the flagged line's own history before "fixing" a shape a recent JIRA-numbered commit introduced on purpose. Co-Authored-By: Vincent Massol <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications