[xwiki/xwiki-platform] 521028: [Misc] Wait for the HTML5 uploader before setting ...
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 521028d8ff774945a1ceec75401fba6952a863aa https://github.com/xwiki/xwiki-platform/commit/521028d8ff774945a1ceec75401fb... Author: Michael Hamann <[email protected]> Date: 2026-09-22 (Tue, 22 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-pageobjects/src/main/java/org/xwiki/flamingo/skin/test/po/AttachmentsPane.java Log Message: ----------- [Misc] Wait for the HTML5 uploader before setting the file to upload AttachmentsPane#setFileToUpload only sent the file path to the file input. The upload itself is started by the change listener that the HTML5 uploader installs on that input, and the uploader is initialized asynchronously, once attachments.js has resolved the 'xwiki-upload' module through RequireJS. Opening the attachments doc extra pane only waits for the pane to be displayed, so the change event could be fired before the listener existed, in which case it was lost and no upload happened at all. This made AttachmentValidationIT#validateDisguisedAttachment fail on CI with a NoSuchElementException on .xnotification-error: the archived video shows the file sitting in the input with the submit buttons still visible, i.e. hideFormButtons() had never run. Wait for the html5upload-initialized marker that the uploader sets on the form, which is added right after the change listener is attached. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: cbd3bb9d446fa4fde1be25b2418d929000ced3be https://github.com/xwiki/xwiki-platform/commit/cbd3bb9d446fa4fde1be25b2418d9... Author: Michael Hamann <[email protected]> Date: 2026-09-22 (Tue, 22 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/SecurityCacheStressIT.java Log Message: ----------- [Misc] Don't run the security cache stress test through the browser The test raised the page load timeout to 10 minutes, but that is not the timeout it was hitting: the Selenium HTTP client gives up on the "get" command after its own read timeout of 3 minutes, and that timeout is fixed when the driver is created, so a test cannot change it. Request the rendered page over HTTP straight from the test JVM instead, where no such timeout applies. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 2d1f0a84318f1600b1f7d2df9c5284b0ec099c06 https://github.com/xwiki/xwiki-platform/commit/2d1f0a84318f1600b1f7d2df9c528... Author: Michael Hamann <[email protected]> Date: 2026-09-22 (Tue, 22 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java Log Message: ----------- [Misc] Add the users created over REST to XWikiAllGroup RestTestUtils#createUser() only added the user object, while the registration also adds the new user to XWikiAllGroup (see XWiki#setUserDefaultGroup()), so users created over REST were less privileged than registered ones. Add them to that group, skipping the ones that are already a member like XWiki#addUserToGroup() does: the group document outlives the user documents, so the membership can still be there when a user of the same name is created again, as NotificationsIT does for each of its tests. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: ab9fb5b14a46f0376759dacff89bb69b089f74d4 https://github.com/xwiki/xwiki-platform/commit/ab9fb5b14a46f0376759dacff89bb... Author: Michael Hamann <[email protected]> Date: 2026-09-22 (Tue, 22 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/SecurityCacheStressIT.java Log Message: ----------- [Misc] Create the users of the security cache stress test over REST RestTestUtils#createUser() creates them without going through the browser, which makes the whole test browser-free. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Compare: https://github.com/xwiki/xwiki-platform/compare/897826f7d2ad...ab9fb5b14a46 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications