[xwiki/xwiki-commons] 03eff3: XCOMMONS-3750: LocalExtensionStorage#removeExtensi...
Branch: refs/heads/XCOMMONS-3750 Home: https://github.com/xwiki/xwiki-commons Commit: 03eff37b7f7dc1891d5efcb85de2cc077b780579 https://github.com/xwiki/xwiki-commons/commit/03eff37b7f7dc1891d5efcb85de2cc... Author: Vincent Massol <[email protected]> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/local/LocalExtensionStorage.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/repository/local/DefaultLocalExtensionRepositoryTest.java Log Message: ----------- XCOMMONS-3750: LocalExtensionStorage#removeExtension() never deletes the extension version folder * delete the extension version folder instead of deleting the extension descriptor file a second time, which threw NoSuchFileException and left both the version folder and the extension folder behind * never delete the repository root folder, nor anything above it, since a descriptor can also be located directly at the root of the repository * catch NoSuchFileException rather than FileNotFoundException, which Files.delete() never throws * log the version folder path, rather than the descriptor path, in the "folder not empty" warning * add regression tests for the extension folder deletion and for keeping the repository root folder To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications
participants (1)
-
XWiki Notifications