[xwiki/xwiki-platform] 4a4fc9: XWIKI-23781: No used values suggested for list fie...
Branch: refs/heads/backport/stable-17.10.x/pr-4912 Home: https://github.com/xwiki/xwiki-platform Commit: 4a4fc9b43c6facde6cf433227f668fd419cba81b https://github.com/xwiki/xwiki-platform/commit/4a4fc9b43c6facde6cf433227f668... Author: Michael Hamann <[email protected]> Date: 2025-12-10 (Wed, 10 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-test/xwiki-platform-livedata-test-docker/src/test/it/org/xwiki/livedata/test/ui/LiveDataIT.java M xwiki-platform-core/xwiki-platform-livetable/xwiki-platform-livetable-ui/src/main/resources/XWiki/LiveTableResultsMacros.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/objects/classes/UsedValuesListQueryBuilder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/GroupsClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/LevelsClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/ListClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/UsersClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/UsedValuesListQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-manager/src/main/java/org/xwiki/query/internal/TextQueryFilter.java M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-manager/src/test/java/org/xwiki/query/internal/TextQueryFilterTest.java Log Message: ----------- XWIKI-23781: No used values suggested for list fields on Oracle (#4912) * Select the property type in UsedValuesListQueryBuilder based on the actual property type. This fixes the used value suggestions for User and Group properties. * Don't use special queries for Oracle unless we're actually using CLOB. * Use a min-query on the object ID for Oracle CLOB values to filter duplicates and use a dummy value to support the code that expects the count value. * Remove the `str()` conversion from `TextQueryFilter` for all columns we use here as it causes problems with long CLOB columns - while `lower()` alone surprisingly works. * Support filtering on list properties with large storage in LiveTableResultsMacros.xml. * Add integration tests in LiveDataIT that hopefully cover all cases of list values. * Use a private record to store the select and from statements to make the code clearer. * Add comments to explain the used aliases. * Add comments about the logic from ListClass and property choices of other list classes being duplicated. (cherry picked from commit cff3976202faff1656bb3487599d92d81fd0a79c) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications