[xwiki-contrib/application-changerequest] eaa1ca: CRAPP-385: Doesn't work with inline edition
Branch: refs/heads/CRAPP-385 Home: https://github.com/xwiki-contrib/application-changerequest Commit: eaa1caa1a3466a7b33ed1d71ea96fd8431cc2c9c https://github.com/xwiki-contrib/application-changerequest/commit/eaa1caa1a3... Author: Simon Urli <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M application-changerequest-default/src/main/java/org/xwiki/contrib/changerequest/internal/handlers/EditChangeRequestResourceHandler.java Log Message: ----------- CRAPP-385: Doesn't work with inline edition * EditChangeRequestResourceHandler never set the "display" context key to "edit" when preparing the editcr view, unlike core's EditAction/SaveAction. As a result, XObject property fields displayed through a sheet's $doc.display() (e.g. a TextArea bound to a class via a sheet) were rendered in read-only view mode instead of as editable fields when reopening a pending change request for editing. * This also affected page creation through a change request (CreateInChangeRequestResourceHandler redirects to the same editcr handler), so the fix covers that flow as well. Co-Authored-By: Claude Sonnet 5 <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-changerequest/settings/notifica...
participants (1)
-
XWiki Notifications