[xwiki/xwiki-platform] d015cc: [Misc] Fix various Java SonarQube issues reported ...
Branch: refs/heads/claude/clever-feynman-kebkgq Home: https://github.com/xwiki/xwiki-platform Commit: d015cc37d88e5042a97c03e2c2aaf56dc671b927 https://github.com/xwiki/xwiki-platform/commit/d015cc37d88e5042a97c03e2c2aaf... Author: Vincent Massol <[email protected]> Date: 2026-08-19 (Wed, 19 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-filter/xwiki-platform-filter-streams/xwiki-platform-filter-stream-xar/src/main/java/org/xwiki/filter/xar/internal/input/AttachmentReader.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/test/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilterPreferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/EditForm.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/criteria/impl/RangeTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/PropertyClassTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem/src/test/java/org/xwiki/store/FileSaveTransactionRunnableTest.java Log Message: ----------- [Misc] Fix various Java SonarQube issues reported by SonarCloud * java:S3415 (15 issues): pass the expected value as the first argument of assertEquals(), so a failure message reads the right way round. All the swapped operands are plain values with a symmetric equals(); the equals()-contract assertions of the same files are left alone. * java:S3252 (7 issues): qualify the WikiAttachmentFilter constants with the interface that declares them instead of with the XWikiWikiAttachmentFilter sub-interface. * java:S1854 + java:S1481 (2 issues): drop the local variable that the computeIfAbsent cleanup of #6178 left unread in XWikiRightServiceImpl; the lazy-init call itself is kept. * java:S1117 (1 issue): rename the computeIfAbsent lambda parameter that #6178 introduced in EditForm, since it hides the "name" field. Co-Authored-By: Vincent Massol <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications