[xwiki-contrib/application-releasenotes] 2e934e: RN-132: Refuse an invalid release note or change w...
Branch: refs/heads/architecture-entry-point Home: https://github.com/xwiki-contrib/application-releasenotes Commit: 2e934e39a8b80d69d3a6af991dc68975a52c41ea https://github.com/xwiki-contrib/application-releasenotes/commit/2e934e39a8b... Author: Vincent Massol <[email protected]> Date: 2026-09-30 (Wed, 30 Sep 2026) Changed paths: A application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/ReleaseNotesInvalidException.java M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/DefaultChangeManager.java M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/DefaultReleaseNoteManager.java M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/ProductResolver.java M application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/internal/DefaultChangeManagerTest.java M application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/internal/DefaultReleaseNoteManagerTest.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/ReleaseNotesExceptionMapper.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/ReleaseNotesExceptionMapperTest.java Log Message: ----------- RN-132: Refuse an invalid release note or change with a dedicated ReleaseNotesInvalidException * New public ReleaseNotesInvalidException, thrown by the managers and by ProductResolver for a release note with no version, a change with no version or no title, and no product in a wiki without a default one * The REST exception mapper answers it with a 400, without logging it * Fix two test comments that still said the managers check rights Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: e73e6e7eef96dc90dbe01942a5cf41d3251262e5 https://github.com/xwiki-contrib/application-releasenotes/commit/e73e6e7eef9... Author: Vincent Massol <[email protected]> Date: 2026-09-30 (Wed, 30 Sep 2026) Changed paths: M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/EntryPageAllocator.java A application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesCaller.java A application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesEntryPoint.java M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesReferences.java M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/script/ReleaseNotesScriptService.java M application-releasenotes-api/src/main/resources/META-INF/components.txt A application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesEntryPointTest.java M application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/script/ReleaseNotesScriptServiceTest.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/AbstractReleaseNotesResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangeResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangesResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNoteResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNotesResource.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangeResourceTest.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangesResourceTest.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNoteResourceTest.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNotesResourceTest.java M application-releasenotes-ui/src/test/java/org/xwiki/contrib/releasenotes/ReleaseNotesApiComponentList.java Log Message: ----------- RN-131: A script can create a change for a release note that does not exist * New internal ReleaseNotesEntryPoint: the one place a script call or a REST request goes through to reach the managers; it locates the page, checks the rights of a ReleaseNotesCaller (current user, plus the script author for a script), checks that a change goes to an existing release note, then calls the manager * The script service and the REST resources only translate their input into an entry-point call; the managers still check no right * The script service now refuses a change for a missing release note, as REST did (ReleaseNotesNotFoundException, a 404 over REST) * A blank version is refused with ReleaseNotesInvalidException before any right check, instead of being skipped by the script service's check and failing later * REST no longer resolves the default product by hand nor repeats the managers' title and version checks * Entry page references are built by ReleaseNotesReferences.entry, shared by EntryPageAllocator and the REST change resource Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Compare: https://github.com/xwiki-contrib/application-releasenotes/compare/2e934e39a8... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...
participants (1)
-
XWiki Notifications