[xwiki/xwiki-platform] ee669d: XWIKI-24646: notification cache can be repopulated...
Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: ee669d2f6da3002f9e61c21b71cc3c191b300680 https://github.com/xwiki/xwiki-platform/commit/ee669d2f6da3002f9e61c21b71cc3... Author: Manuel Leduc <[email protected]> Date: 2026-08-13 (Thu, 13 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/pom.xml M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/DefaultAsyncNotificationRenderer.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/DefaultNotificationCacheManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultAsyncNotificationRendererTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultNotificationCacheManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-rest/src/main/java/org/xwiki/notifications/rest/internal/NotificationEventExecutor.java A xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-rest/src/test/java/org/xwiki/notifications/rest/internal/NotificationEventExecutorTest.java Log Message: ----------- XWIKI-24646: notification cache can be repopulated with an outdated result after its invalidation (#6034) * Add a counter (epoch) to avoid caching outdated notification results. * Fix the gap between checking the epoch and storing the cached value by making the epoch part of the cache key. Keep the removal of the cached value to avoid that the cache accumulates outdated values. * Adapt the tests to use an actual cache implementation. * Add a test that verifies the race condition. * Improve and add tests. Co-authored-by: Michael Hamann <[email protected]> Co-authored-by: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit 44684246df3be9933d0c7dbfaaa09aa2cc24d1e4) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications