[xwiki/xwiki-platform] cc41b3: XWIKI-24751: The inplace editor still locks the or...
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: cc41b30e17385c310213e18fba16a60eafd16088 https://github.com/xwiki/xwiki-platform/commit/cc41b30e17385c310213e18fba16a... Author: Marius Dumitru Florea <[email protected]> Date: 2026-08-27 (Thu, 27 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-edit/xwiki-platform-edit-test/xwiki-platform-edit-test-docker/src/test/it/org/xwiki/edit/test/ui/InplaceTranslateIT.java M xwiki-platform-core/xwiki-platform-edit/xwiki-platform-edit-test/xwiki-platform-edit-test-pageobjects/src/main/java/org/xwiki/edit/test/po/InplaceEditablePage.java M xwiki-platform-core/xwiki-platform-edit/xwiki-platform-edit-ui/src/main/resources/XWiki/InplaceEditing.xml M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/ViewPage.java Log Message: ----------- XWIKI-24751: The inplace editor still locks the original translation when creating a new translation * Acquire the edit lock through the edit action, which resolves the document translation that is going to be edited (the context translation falls back on the default one when the requested translation doesn't exist yet) and locks it, instead of redirecting to the lock action with a locale computed from the context translation. This also makes the edit confirmation checkers see the translation being created, so they report its lock rather than the one of the default translation. * Fix ViewPage#hasTranslateButton(), which passed a CSS selector to By#id and thus always returned false, making the existing assertions on it pass vacuously. * Add an integration test checking that only the translation being created is locked, covering both ways of starting the creation of a new translation: directly from the Translate button and while already editing the original translation. Co-Authored-By: Claude Opus 5 <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications