[xwiki-contrib/application-releasenotes] 5ba0b4: RN-111: The application pages do not declare the r...
Branch: refs/heads/RN-111 Home: https://github.com/xwiki-contrib/application-releasenotes Commit: 5ba0b49faa18549c0fc167c8e8ceb38e6c5589a6 https://github.com/xwiki-contrib/application-releasenotes/commit/5ba0b49faa1... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ApplicationsPanelEntry.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerFlow.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerGrid.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerList.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerSimple.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/GetChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HTML5Video.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/MigrationFrom1x.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNoteClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfig.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfigClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Report.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebPreferences.xml M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/RequiredRightsTest.java Log Message: ----------- RN-111: The application pages do not declare the rights they require * Raise the five XWiki.WikiMacroClass pages from script to wiki_admin. DefaultWikiMacroFactory.isAllowed checks Right.ADMIN at EntityType.WIKI against the macro document's author for a macro whose visibility is Current Wiki, so capping the author at script left all five macros unregistered and every page using one rendered "Unknown macro". The required-rights analyzer reports script here because no analyzer reads WikiMacroClass visibility, unlike the UI extension and translation bundle ones, so the declared level departs from it on purpose and RequiredRightsTest carries the reason. * Declare the XAR document-model version as 1.6 on the pages carrying enforceRequiredRights, the version that introduced the element. * Read the rights back through DocumentRequiredRightsManager in RequiredRightsTest, as a PageTest, so the assertion is about what the platform enforces rather than about the XML that carries it. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...
participants (1)
-
XWiki Notifications