[xwiki-contrib/application-changerequest] 2610a2: CRAPP-25: Notifications are not properly displayed...
Branch: refs/heads/main Home: https://github.com/xwiki-contrib/application-changerequest Commit: 2610a2d8fe9b616c322ad4e8f39000b1859a02c9 https://github.com/xwiki-contrib/application-changerequest/commit/2610a2d8fe... Author: Simon Urli <[email protected]> Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: M application-changerequest-notifications/src/main/java/org/xwiki/contrib/changerequest/internal/ChangeRequestNotificationDisplayer.java M application-changerequest-notifications/src/main/java/org/xwiki/contrib/changerequest/internal/converters/AbstractChangeRequestRecordableEventConverter.java A application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/ChangeRequestNotificationDisplayerTest.java M application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/converters/ChangeRequestCreatedRecordableEventConverterTest.java M application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/converters/ChangeRequestDiscussionRecordableEventConverterTest.java M application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/converters/ChangeRequestFileChangeAddedRecordableEventConverterTest.java M application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/converters/ChangeRequestRebasedRecordableEventConverterTest.java M application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/converters/ChangeRequestReviewAddedRecordableEventConverterTest.java M application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/converters/ChangeRequestStatusChangedRecordableEventConverterTest.java M application-changerequest-notifications/src/test/java/org/xwiki/contrib/changerequest/internal/converters/DefaultChangeRequestRecordableEventConverterTest.java Log Message: ----------- CRAPP-25: Notifications are not properly displayed because of the Mark as read behaviour * Split the composite events before displaying them in the displayer to workaround the issue with events that shouldn't be grouped together * Refactor a bit the displayer to remove unnecessary checks and provide unit test * Refactor converter to use Event#custom instead of Event#parameters which is now deprecated
participants (1)
-
XWiki Notifications