[xwiki/xwiki-dev-llm] 19af3b: [Misc] Correct the java:S6213 denylist entry: only...
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: 19af3b500441f7ee8e2a31139b17031dce763b6f https://github.com/xwiki/xwiki-dev-llm/commit/19af3b500441f7ee8e2a31139b1703... Author: Vincent Massol <[email protected]> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/syntax-rules.md Log Message: ----------- [Misc] Correct the java:S6213 denylist entry: only the method half is an API change * The entry rejects the whole rule because "a rename of a public method or field is an API change", but that is only true of the "Rename this method" half. "Rename this variable" is a parameter/local rename that changes no signature, and the message alone classifies each site. * Documented the variable half in syntax-rules with the two mechanics that make it scriptable (the look-behind that spares method calls, and skipping comment lines so the rename doesn't mangle prose). Co-Authored-By: Vincent Massol <[email protected]> Commit: 9ef09dc7a93ed6fabd9937a81272538c7f515118 https://github.com/xwiki/xwiki-dev-llm/commit/9ef09dc7a93ed6fabd9937a8127253... Author: Vincent Massol <[email protected]> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki/okf/conventions/code-comments.md M xwiki/okf/conventions/code-style.md Log Message: ----------- [Misc] Record two comment conventions enforced in review * An empty catch needs a "// TODO:" asking to log a warning or to change the logic, not just a rationale comment: a catch that neither rethrows nor logs is a bug to fix later, not a decision to document. * A Javadoc comment is always multi-line, never the one-line form, and a file still using the one-line form gets converted when it is touched. Neither rule is on the dev wiki CodeStyle page. Co-Authored-By: Vincent Massol <[email protected]> Commit: 3c3b4d68308de2517dcee0be11cca577d6d54820 https://github.com/xwiki/xwiki-dev-llm/commit/3c3b4d68308de2517dcee0be11cca5... Author: Vincent Massol <[email protected]> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki/okf/conventions/code-comments.md Log Message: ----------- [Misc] Scope the TODO rule to swallowed exceptions, not to every empty block Co-Authored-By: Vincent Massol <[email protected]> Commit: be779c8896ab3e258af344684d992998810ddbfa https://github.com/xwiki/xwiki-dev-llm/commit/be779c8896ab3e258af344684d9929... Author: Vincent Massol <[email protected]> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki/okf/conventions/code-comments.md M xwiki/okf/conventions/code-style.md Log Message: ----------- [Misc] Drop the empty-catch TODO rule: it has false positives * Requested in review: the OKF should hold only rules that don't yield false positives, and this one does — a catch of a domain "not found" exception used as a signal is the design, not a defect to be TODO-ed. * The Javadoc multi-line rule stays; it has no such exception. Co-Authored-By: Vincent Massol <[email protected]> Commit: eb967d47a9ad01b7e01c9228c9756ecae6b73b20 https://github.com/xwiki/xwiki-dev-llm/commit/eb967d47a9ad01b7e01c9228c9756e... Author: Vincent Massol <[email protected]> Date: 2026-09-01 (Tue, 01 Sep 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json Log Message: ----------- [Misc] Drop the plugin version bump * Five manifests carry one version, so every concurrent pull request conflicted with every other one on those same five lines, over something that was never part of either change. The release is now cut on master after the merge by scripts/release.mjs, and scripts/validate.mjs fails a branch that touches a version field. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 3ec80f445aa8c2365b2baa2c7b39c26c374a8820 https://github.com/xwiki/xwiki-dev-llm/commit/3ec80f445aa8c2365b2baa2c7b39c2... Author: Vincent Massol <[email protected]> Date: 2026-09-01 (Tue, 01 Sep 2026) Changed paths: M .claude-plugin/marketplace.json A .github/workflows/release.yml M CLAUDE.md M README.md M kimi.plugin.json M opencode.jsonc A scripts/release.mjs M scripts/validate.mjs M xwiki/.claude-plugin/plugin.json M xwiki/.mcp.json M xwiki/instructions/xwiki-org.md A xwiki/okf/architecture/wiki-application-data.md M xwiki/okf/conventions/documentation-migration.md M xwiki/okf/conventions/documentation.md M xwiki/okf/conventions/frontend.md M xwiki/okf/index.md M xwiki/okf/servers/index.md M xwiki/okf/servers/jenkins.md M xwiki/okf/servers/jira.md M xwiki/okf/sonarqube/constant-and-resource-rules.md M xwiki/okf/sonarqube/dead-code-rules.md M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/modernization-rules.md M xwiki/okf/sonarqube/simplification-rules.md M xwiki/okf/sonarqube/syntax-rules.md M xwiki/okf/sonarqube/test-code-rules.md M xwiki/okf/sonarqube/verification.md A xwiki/okf/testing/running-docker-its.md M xwiki/okf/testing/strategy.md M xwiki/scripts/inject-org-instructions.mjs A xwiki/scripts/xwiki-it-slot.mjs M xwiki/skills/xwiki-build/SKILL.md M xwiki/skills/xwiki-doc-convert/SKILL.md A xwiki/skills/xwiki-doc-convert/references/conversion-plan.md M xwiki/skills/xwiki-doc-writing/SKILL.md M xwiki/skills/xwiki-doc-writing/tools/README.md M xwiki/skills/xwiki-doc-writing/tools/docpages.py A xwiki/skills/xwiki-doc-writing/tools/docplan.py M xwiki/skills/xwiki-doc-writing/tools/docshot.sh M xwiki/skills/xwiki-doc-writing/tools/xwikidoc.py M xwiki/skills/xwiki-fix-sonarqube-issue/SKILL.md M xwiki/skills/xwiki-knowledge/SKILL.md M xwiki/skills/xwiki-pull-request/SKILL.md M xwiki/skills/xwiki-rest-api/SKILL.md M xwiki/skills/xwiki-review/SKILL.md M xwiki/skills/xwiki-test-guidelines/SKILL.md Log Message: ----------- [Misc] Merge master to pick up the merge-base version check * The branch was failing `validate` because it ran its own stale copy of scripts/validate.mjs, which still required a bump above master's tip; master now requires the opposite — a pull request must not touch the version at all, since the release is cut on master. * No version bump here: the manifests take master's 1.5.1 unchanged. Co-Authored-By: Vincent Massol <[email protected]> Commit: b0f7ac40b9a7be624d24428b46fec8a9e161bbcf https://github.com/xwiki/xwiki-dev-llm/commit/b0f7ac40b9a7be624d24428b46fec8... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M xwiki/okf/conventions/code-style.md M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/syntax-rules.md Log Message: ----------- Merge pull request #77 from xwiki/claude/cool-tesla-6a1n0j [Misc] Correct the java:S6213 denylist entry, and record the multi-line Javadoc convention Compare: https://github.com/xwiki/xwiki-dev-llm/compare/812f1f35394d...b0f7ac40b9a7 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications
participants (1)
-
XWiki Notifications