[xwiki/xwiki-platform] 62da0d: XWIKI-24621: Notification watch settings can silen...
Branch: refs/heads/XWIKI-24621 Home: https://github.com/xwiki/xwiki-platform Commit: 62da0d02339f0ed4c3c0b589ed9ca981158d9486 https://github.com/xwiki/xwiki-platform/commit/62da0d02339f0ed4c3c0b589ed9ca... Author: Vincent Massol <[email protected]> Date: 2026-08-12 (Wed, 12 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-ui/src/main/resources/XWiki/Notifications/Code/NotificationsWatchUIX.xml Log Message: ----------- XWIKI-24621: Notification watch settings can silently fail to be saved * Handle the failure path again. The handler registered its failure callback with the jqXHR error() method, removed in jQuery 3.0 and no longer restored by jQuery Migrate 4, so registering it threw a TypeError and left the failure path unhandled: a request that failed was silently ignored, with no feedback at all for the user. It now uses catch(). * Apply the two changes of the combined options one after another, awaiting each one, instead of passing an already started request to the deprecated pipe(). Both changes were sent concurrently and the page could be reloaded while the second one was still in flight, silently dropping it. * Return a rejected promise for an unsupported option, so that performChange() always returns a promise. The guards comparing its result against the string 'undefined' never matched, and the handler threw when no request was sent. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications