[xwiki/xwiki-platform] aac47a: XWIKI-24779: FeedPlugin.EntriesComparator never so...
Branch: refs/heads/XWIKI-24779 Home: https://github.com/xwiki/xwiki-platform Commit: aac47a12146339e07619db957951dfc04df292ba https://github.com/xwiki/xwiki-platform/commit/aac47a12146339e07619db957951d... Author: Vincent Massol <[email protected]> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/pom.xml M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java A xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/test/java/com/xpn/xwiki/plugin/feed/FeedPluginTest.java Log Message: ----------- XWIKI-24779: FeedPlugin.EntriesComparator never sorts anything because it reads both objects from the first entry * Read the date of the second entry instead of reading the first entry twice, so that the feed search results are really ordered by descending date. * Read the date property through the API object rather than through getXWikiObject(), which returns null when the caller has no programming rights and made the comparison throw a NullPointerException. * Express both comparators with Comparator.comparing()/nullsLast()/reverseOrder(), which states the ordering instead of encoding it in a negated comparison. * Add unit tests for both comparators and raise the module's JaCoCo instruction ratio to the newly achieved 0.18. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications