Branch: refs/heads/okf-script-services-and-required-rights Home: https://github.com/xwiki/xwiki-dev-llm Commit: aa47fa8d1deb55aedf7230f32b48326ed1e98ac9 https://github.com/xwiki/xwiki-dev-llm/commit/aa47fa8d1deb55aedf7230f32b4832... Author: Vincent Massol <[email protected]> Date: 2026-09-09 (Wed, 09 Sep 2026) Changed paths: M xwiki/instructions/xwiki-org.md M xwiki/okf/architecture/required-rights.md A xwiki/okf/conventions/script-services.md M xwiki/okf/index.md M xwiki/okf/sonarqube/index.md Log Message: ----------- [Misc] Record the script-service error convention and correct how required rights propagate * Add okf/conventions/script-services.md: a new script service throws and callers use #try() (the return-null-and-getLastError() contract predates that directive), an existing signature must not be changed for backward compatibility, and the Method Arguments Uberspector plus a registered Converter is why a service never needs bean-factory methods. * Say so on the S2447 entry of okf/sonarqube/index.md, which stated the legacy contract as if it were the current convention. The drop condition itself is unchanged: leave existing script APIs alone. * Correct okf/architecture/required-rights.md, whose claims about propagation were both wrong. Required rights are read for the current sdoc alone, so an enforcing page caps neither a page it includes nor a wiki macro it calls, whatever the include's author parameter says. Only a script save (com.xpn.xwiki.api.Document#save) forces enforcement onto what it saves; XWiki#saveDocument, which a Java component calls, does not. Add the trap that costs the most time: an empty enforced set makes a Velocity title display as raw source, since a title is evaluated only for a content author holding script right. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications