[xwiki/xwiki-platform] 8f59ec: XWIKI-24590: Create/check for automated tests for ...
Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 8f59ecc724e1d6f99f89108d79ccac73cfb78ffe https://github.com/xwiki/xwiki-platform/commit/8f59ecc724e1d6f99f89108d79cca... Author: Vincent Massol <[email protected]> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/src/test/it/org/xwiki/flamingo/test/ui/FlamingoThemeIT.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/editor/EditPage.java Log Message: ----------- XWIKI-24590: Create/check for automated tests for "Buttons Default Background" (#6030) Automate the "Buttons Default Background" manual test in FlamingoThemeIT: set the @btn-default-bg variable from the "Buttons" category of the color theme editor and verify that a button using the default style (the editor "Cancel" button) gets the configured background on a wiki page. Co-authored-by: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit c9eafc0ad7d5e7a88610bb8b2426deeb6f6294e2) Commit: 424e266aed00b694d3392a39baec3d1adef64f42 https://github.com/xwiki/xwiki-platform/commit/424e266aed00b694d3392a39baec3... Author: Vincent Massol <[email protected]> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/src/test/it/org/xwiki/flamingo/test/ui/FlamingoThemeIT.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/ViewPage.java Log Message: ----------- XWIKI-24589: Create/check for automated tests for "Base Colors Text Color" (#6038) Automate the "Base Colors Text Color" manual test in FlamingoThemeIT: set the @text-color variable from the "Base colors" category of the color theme editor and verify that the resulting text color is applied, both in the theme editor preview and on wiki pages using the theme. The text color is asserted on the "body" element because the 'lessCode' variable the test already sets colors the whole ".main" block, which contains the page content. Co-authored-by: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit 8e489563a5dc67b7d37baaa97efd315e75150edb) Commit: 24226f100deb036dde5a87a86fc2cdf0a7837774 https://github.com/xwiki/xwiki-platform/commit/24226f100deb036dde5a87a86fc2c... Author: Vincent Massol <[email protected]> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/pom.xml M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/src/test/it/org/xwiki/flamingo/test/ui/FlamingoThemeIT.java A xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/src/test/resources/logo.png M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-pageobjects/src/main/java/org/xwiki/flamingo/test/po/EditThemePage.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/BasePage.java Log Message: ----------- XWIKI-24592: Create/check for automated tests for "Change Theme Logo" (#6039) * Automate the "Change Theme Logo" manual test: set a color theme logo by uploading an image with the attachment picker of the theme editor and verify that it's displayed as the wiki logo once the theme is used. * Add the page object methods needed to drive the image variables of the theme editor and to read the logo displayed in the page header. Co-authored-by: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit d8fc8149211124945aced1ed476962ab3da99681) Commit: c007474088fdec4199cf7e98fb672f70d191b001 https://github.com/xwiki/xwiki-platform/commit/c007474088fdec4199cf7e98fb672... Author: Vincent Massol <[email protected]> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/src/test/it/org/xwiki/flamingo/test/ui/FlamingoThemeIT.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/ViewPage.java Log Message: ----------- XWIKI-24693: Add automated tests for "Base Colors Brand Danger" (#6159) Also covers: * XWIKI-24694: Add automated tests for "Base Colors Brand Info" * XWIKI-24695: Add automated tests for "Base Colors Brand Primary" The 3 manual tests exercise 3 variables of the same "Base colors" category of the color theme editor and share the same expensive create-theme-and-apply-it flow, so a single test covers them. * Added FlamingoThemeIT#changeBaseBrandColors, which sets the brand primary, brand info and brand danger variables of the "Base colors" category in a new color theme, applies that theme to the wiki and verifies that the 3 colors reach the browser. The brand info and brand danger colors are checked through the "notificationInfoColor" and "notificationErrorColor" color theme variables they are mapped to. The brand primary color is not mapped to any color theme variable, so it is checked through the "text-primary" style of the skin, which uses it. * Made ViewPage#getElementCSSValue() public so that a test can read the color of an element without reaching for the WebDriver itself. Co-authored-by: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit 081227ef9fe5e48527f146a0d5ba742c3b78f5b5) Commit: 5b3ba150a538fa439cc0b94b11bf1e6e7329a9c2 https://github.com/xwiki/xwiki-platform/commit/5b3ba150a538fa439cc0b94b11bf1... Author: Vincent Massol <[email protected]> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/colorPicker.js M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/localePicker.js M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/src/test/it/org/xwiki/flamingo/test/ui/FlamingoThemeIT.java M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-pageobjects/src/main/java/org/xwiki/flamingo/test/po/EditThemePage.java Log Message: ----------- XWIKI-23180: The color pickers from Theme customization are not always loading (#6161) * Register the 'xwiki:dom:loaded' listener in colorPicker.js and localePicker.js instead of relying only on the XWiki.domIsLoaded flag, which is still false when the RequireJS callback resolves before the DOM is ready * Require the events bridge in colorPicker.js, needed for the Prototype-fired 'xwiki:dom:updated' event to reach the jQuery listener * Set the first brand color of the FlamingoThemeIT theme editor test with the color picker, and check the color preview boxes, so that the test fails if the pickers are not initialized Co-authored-by: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit 4f1e724a2f21808e9abffae3bec42d9d7e4c1f79) Commit: 62e011cb6536ffba42b06e7e53b5b746d491c32d https://github.com/xwiki/xwiki-platform/commit/62e011cb6536ffba42b06e7e53b5b... Author: LucasC <[email protected]> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker/src/test/it/org/xwiki/flamingo/test/ui/FlamingoThemeIT.java Log Message: ----------- XWIKI-24593: Create/check for automated tests for "Typography Font Family Sans Serif" (#6029) * XWIKI-24593: Create/check for automated tests for "Typography Font Family Sans Serif" * Added a test in the FlamingoThemeIT test suite that checks that the sans serif variable works as expected with a keyword * XWIKI-24593: Create/check for automated tests for "Typography Font Family Sans Serif" * Moved the new test to a better place in its file. * XWIKI-24593: Create/check for automated tests for "Typography Font Family Sans Serif" * Replaced the new test with assertions in an existing test. * XWIKI-24593: Create/check for automated tests for "Typography Font Family Sans Serif" * Extracted the duplicated preview refresh retry into a refreshPreviewWithRetry() method. * Explained inline why the "math" CSS generic font family is used, and removed the JIRA link from the comment. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> --------- Co-authored-by: Vincent Massol <[email protected]> Co-authored-by: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit 7a4c77545c6e7a17311e2fb09e8b8269738f3dd0) Compare: https://github.com/xwiki/xwiki-platform/compare/ee669d2f6da3...62e011cb6536 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications