Branch: refs/heads/sonarqube-fixes Home: https://github.com/xwiki/xwiki-commons Commit: 682f56dfd78cbd477bb68e52293d4a7e9028754a https://github.com/xwiki/xwiki-commons/commit/682f56dfd78cbd477bb68e52293d4a... Author: Vincent Massol <[email protected]> Date: 2026-07-27 (Mon, 27 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-cipher/src/test/java/org/xwiki/crypto/cipher/internal/symmetric/factory/AbstractSymmetricCipherFactoryTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-pkix/src/test/java/org/xwiki/crypto/signer/internal/cms/DefaultCMSSignedDataTest.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/test/java/org/xwiki/filter/internal/AbstractFilterDescriptorManagerTest.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/test/Utils.java Log Message: ----------- [Misc] Remove useless assignments to local variables (SonarQube java:S1854) * Dead stores reported by SonarCloud; side-effecting calls kept as plain statements. Co-Authored-By: Kimi Code <[email protected]> Commit: 9d3f3d4db22362b325c4d0664a196d87c3aed330 https://github.com/xwiki/xwiki-commons/commit/9d3f3d4db22362b325c4d0664a196d... Author: Vincent Massol <[email protected]> Date: 2026-07-27 (Mon, 27 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/Base64BinaryStringEncoderTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/HexBinaryStringEncoderTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/UrlBase64BinaryStringEncoderTest.java Log Message: ----------- [Misc] Replace string concatenations with text blocks in encoder tests (SonarQube java:S6126) Co-Authored-By: Kimi Code <[email protected]> Commit: f27100b03f6326c258d7b450194076b5613c5808 https://github.com/xwiki/xwiki-commons/commit/f27100b03f6326c258d7b450194076... Author: Vincent Massol <[email protected]> Date: 2026-07-27 (Mon, 27 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/event/LogEventTest.java M xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-filesystem/src/test/java/org/xwiki/store/blob/internal/FileSystemBlobStoreTest.java Log Message: ----------- [Misc] Fix expected/actual argument order in assertions (SonarQube java:S3415) Co-Authored-By: Kimi Code <[email protected]> Commit: 2b48f57d4a1f205aa4d9afd352245e3fe0e76765 https://github.com/xwiki/xwiki-commons/commit/2b48f57d4a1f205aa4d9afd352245e... Author: Vincent Massol <[email protected]> Date: 2026-07-27 (Mon, 27 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/marker/TranslationMarkerTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/event/ActionExecutionEventTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/event/CancelableEventTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/filter/AlwaysMatchingEventFilterTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/filter/FixedNameEventFilterTest.java M xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-api/src/test/java/org/xwiki/store/blob/BlobRangeOptionTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals instead of assertTrue/assertFalse with equals() (SonarQube java:S5785) Co-Authored-By: Kimi Code <[email protected]> Commit: e8a328e78f6335b5f3f769f1fe6827c9003517dd https://github.com/xwiki/xwiki-commons/commit/e8a328e78f6335b5f3f769f1fe6827... Author: Vincent Massol <[email protected]> Date: 2026-07-27 (Mon, 27 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/ExtensionPackager.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/FileExtensionRepository.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-test/src/main/java/org/xwiki/filter/test/integration/TestDataParser.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-test/src/main/java/org/xwiki/filter/test/internal/ZIPFileAssertComparator.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-common/src/main/java/org/xwiki/logging/internal/tail/AbstractFileLoggerTail.java Log Message: ----------- [Misc] Use try-with-resources where semantics are preserved (SonarQube java:S2093) * AbstractFileLoggerTail: extracted the read block into a private helper holding the try-with-resources (checkstyle NestedTryDepth); close order and error path unchanged. Co-Authored-By: Kimi Code <[email protected]> Compare: https://github.com/xwiki/xwiki-commons/compare/ea8c42a09e4e...e8a328e78f63 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications