Branch: refs/heads/XWIKI-24172-recyclebin-restore-flicker Home: https://github.com/xwiki/xwiki-platform Commit: 497ecaf6ed52d54972859d02403426757e8e9d1f https://github.com/xwiki/xwiki-platform/commit/497ecaf6ed52d54972859d0240342... Author: Vincent Massol <[email protected]> Date: 2026-09-21 (Mon, 21 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RecycleBinIT.java M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-pageobjects/src/main/java/org/xwiki/flamingo/skin/test/po/AttachmentsPane.java Log Message: ----------- XWIKI-24172: RecycleBinIT#restore is flickering * The test uploaded an attachment with setFileToUpload(), which is asynchronous and returns immediately, and then went straight on to open the "More actions" menu to delete the page. When the upload completes, attachments.js reacts to xwiki:html5upload:done by refreshing the attachments live data and then rewriting the "Attachments" entry of that same "More actions" menu, in which tmAttachments and tmActionDelete are siblings. The menu was thus being rewritten while the test clicked through it, the Delete click could be lost, and the subsequent clickYes() then found no confirmation button on what was still the view page. * Wait for the upload notification and for the attachments count to be refreshed before deleting. The count is the last thing that chain writes, so waiting for it proves the menu rewrite is over; the upload notification alone is not enough since it is shown before the live data refresh, which is a network round trip and is exactly the race window. * Add AttachmentsPane#waitForNumberOfAttachments() for this, so that any other test uploading an attachment before using the "More actions" menu can rely on it. * Verified on chrome / mysql latest / tomcat 11-jdk25, the only configuration in which the test fails on the CI (2 failures out of 12 runs there over the last 28 days, 0 out of 539 elsewhere). Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications