[xwiki/xwiki-platform] 913add: XWIKI-24796: Live Data fails to render in PDF expo...
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 913add313dc9c6533b51f57949284db595262cc0 https://github.com/xwiki/xwiki-platform/commit/913add313dc9c6533b51f57949284... Author: Marius Dumitru Florea <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/pom.xml A xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/src/main/java/org/xwiki/uiextension/internal/UIExtensionRenderer.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/src/main/java/org/xwiki/uiextension/script/UIExtensionScriptService.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/src/test/java/org/xwiki/uiextension/internal/UIExtensionRendererTest.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/src/test/java/org/xwiki/uiextension/script/UIExtensionScriptServiceTest.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/script/UIExtensionScriptServiceComponentList.java Log Message: ----------- XWIKI-24796: Live Data fails to render in PDF export on 17.10.x * Add $services.uix.render($uix, 'html/5.0') and $services.uix.renderExtensions('extensionPointId', 'html/5.0') to execute and render UI extensions in a specified output syntax. * Execute the UI extensions with the specified output syntax as target syntax, so that the content produced by a template based or wiki based UI extension is not dropped when the target syntax found in the rendering context is different from the syntax used to render the result. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: fcb551c83e57585b2632198b456ecd30270a03d0 https://github.com/xwiki/xwiki-platform/commit/fcb551c83e57585b2632198b456ec... Author: Marius Dumitru Florea <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/pom.xml M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/main/java/org/xwiki/uiextension/internal/AbstractWikiUIExtension.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/WikiUIExtensionTest.java Log Message: ----------- XWIKI-24796: Live Data fails to render in PDF export on 17.10.x * Take the target syntax and the inline flag into account in the identifier used to cache the result of executing a wiki based UI extension, because they both influence that result. Without this, rendering the same UI extension in two different output syntaxes returns the cached result of the first syntax, which is then silently dropped by the renderer of the second syntax. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: c8d1f332e6b9933f105e5049c831c508cb967040 https://github.com/xwiki/xwiki-platform/commit/c8d1f332e6b9933f105e5049c831c... Author: Marius Dumitru Florea <[email protected]> Date: 2026-09-08 (Tue, 08 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-alerts/xwiki-platform-alerts-ui/src/main/resources/XWiki/Alerts/Code/AlertsMenuUIX.xml M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-ui/src/main/resources/XWiki/Captcha/Administration.xml M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-ui/src/main/resources/CKEditor/ContentSheet.xml M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/contentheader.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/contentview.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/docdoesnotexist.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/drawer.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/export_modal.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/global.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/htmlheader.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/loaddocextrauix.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/menus_content.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/menus_macros.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/view.vm M xwiki-platform-core/xwiki-platform-panels/xwiki-platform-panels-ui/src/main/resources/Panels/DocumentInformation.xml M xwiki-platform-core/xwiki-platform-panels/xwiki-platform-panels-ui/src/test/java/org/xwiki/panels/IncludedPagesDocumentInformationPageTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-ui/src/main/resources/XWiki/SearchAttachmentDoesNotExistUIX.xml M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-ui/src/main/resources/XWiki/SearchDocumentDoesNotExistUIX.xml M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-test/xwiki-platform-uiextension-test-docker/src/test/it/org/xwiki/uiextension/test/ui/UIExtensionIT.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-profile/xwiki-platform-user-profile-ui/src/main/resources/XWiki/XWikiUserSheet.xml M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-profile/xwiki-platform-user-profile-ui/src/test/java/org/xwiki/user/profile/UserProfilePageTest.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/attachment_macros.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/attachmentdoesnotexist.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/children.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/editpanels.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/informationinline.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/leftpanels.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/rightpanels.vm M xwiki-platform-core/xwiki-platform-whatsnew/xwiki-platform-whatsnew-api/src/main/resources/templates/whatsnew.vm M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-ui/src/main/resources/XWiki/WYSIWYG/ImageSelectorService.xml Log Message: ----------- XWIKI-24796: Live Data fails to render in PDF export on 17.10.x * Render the UI extensions with $services.uix.render() / $services.uix.renderExtensions() in the Velocity templates and in the wiki pages that need the output as a string, so that the UI extensions are executed with the output syntax they are rendered in. * Render the UI extensions with the {{uiextension}} macro in the wiki pages that insert the result in wiki content, which is the recommended approach in wiki syntax. * Render the UI extensions in the html/5.0 syntax everywhere, instead of xhtml/1.0 for some of them. The output syntax was inconsistent, with the same extension point being rendered in different syntaxes depending on the template. * Register the components needed by the UI extension script service and by the {{uiextension}} macro in the page tests that render migrated pages. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: b6dddd124fa7b8385c4e13a4068b2371c791e1e6 https://github.com/xwiki/xwiki-platform/commit/b6dddd124fa7b8385c4e13a4068b2... Author: Marius Dumitru Florea <[email protected]> Date: 2026-09-08 (Tue, 08 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/pom.xml A xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/UIExtensionRenderingPageTest.java Log Message: ----------- XWIKI-24796: Live Data fails to render in PDF export on 17.10.x * Add a page test that renders UI extensions from a page whose output syntax is plain/1.0, to verify on the full chain (rendering context, wiki UI extension, asynchronous renderer, renderer) that the UI extensions are executed with the requested output syntax, and that they were indeed dropped before. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Compare: https://github.com/xwiki/xwiki-platform/compare/847e5fe7b3c8...b6dddd124fa7 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications