[xwiki-contrib/documentation] 093399: DA-114: Improve escaping in the SCM macro
Branch: refs/heads/vmassol/DA-114-119 Home: https://github.com/xwiki-contrib/documentation Commit: 093399a8245babb3f04fb7bc381588775e8418d5 https://github.com/xwiki-contrib/documentation/commit/093399a8245babb3f04fb7... Author: Vincent Massol <[email protected]> Date: 2026-10-15 (Thu, 15 Oct 2026) Changed paths: M documentation-xwikiorg/documentation-xwikiorg-ui/pom.xml M documentation-xwikiorg/documentation-xwikiorg-ui/src/main/resources/DocApp/Code/SCMMacro.xml A documentation-xwikiorg/documentation-xwikiorg-ui/src/test/java/org/xwiki/contrib/documentation/xwikiorg/ui/SCMMacroPageTest.java Log Message: ----------- DA-114: Improve escaping in the SCM macro * Insert the macro content in the link label with the wikimacrocontent macro instead of writing it into the generated wiki syntax, and declare the content as wiki content. * Add page test infrastructure to documentation-xwikiorg-ui (xwiki-platform-test-page and the wiki macro store test-jar). * Add SCMMacroPageTest, checking the generated link and that special characters in the label are kept in the label. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: c92ddfc6f1c8c7f02709f846c47f609f9a8df0a6 https://github.com/xwiki-contrib/documentation/commit/c92ddfc6f1c8c7f02709f8... Author: Vincent Massol <[email protected]> Date: 2026-10-15 (Thu, 15 Oct 2026) Changed paths: M documentation-xwikiorg/documentation-xwikiorg-ui/src/main/resources/DocApp/Code/ExtensionBadge.xml A documentation-xwikiorg/documentation-xwikiorg-ui/src/test/java/org/xwiki/contrib/documentation/xwikiorg/ui/ExtensionBadgePageTest.java Log Message: ----------- DA-115: Improve escaping in the Extension badge * URL-encode the extension id passed in the queryString link parameter (this also covers the ':' that was replaced by hand), and handle the "xwiki:" and unprefixed ids in a single branch. * Escape the '~', '>>', '||' and ']]' sequences of the NPM link reference. * Add ExtensionBadgePageTest, rendering the UI extension content for a page holding a DocumentationExtensionClass object. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: 702a312d36674994b7c2aa331e53d5ba9d1e6bbf https://github.com/xwiki-contrib/documentation/commit/702a312d36674994b7c2aa... Author: Vincent Massol <[email protected]> Date: 2026-10-15 (Thu, 15 Oct 2026) Changed paths: M documentation-ui/pom.xml M documentation-ui/src/main/resources/DocApp/Code/TargetBadge.xml M documentation-ui/src/main/resources/DocApp/Code/TypeBadge.xml A documentation-ui/src/test/java/org/xwiki/contrib/documentation/ui/TypeAndTargetBadgesPageTest.java Log Message: ----------- DA-116: Improve escaping in the Type and Target badges * Escape the type and the target for the xwiki/2.1 syntax before writing them as badge text, and escape them a second time when they're used as a link label, since a link label is unescaped once more when it's parsed. * Escape the '~', '>>', '||' and ']]' sequences of the link reference to the type and target pages. * Add page test infrastructure to documentation-ui (xwiki-platform-test-page, the rendering script service and rendering configuration test-jars, and the web templates for the global Velocity macros). * Add TypeAndTargetBadgesPageTest, rendering the UI extension contents for a page holding a DocumentationClass object, with and without an existing type or target page. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: a9273f9db8836e342d7d4390f6d13bc75f629315 https://github.com/xwiki-contrib/documentation/commit/a9273f9db8836e342d7d43... Author: Vincent Massol <[email protected]> Date: 2026-10-15 (Thu, 15 Oct 2026) Changed paths: M documentation-ui/pom.xml M documentation-ui/src/main/resources/DocApp/Code/DeprecatedMacro.xml M documentation-ui/src/main/resources/DocApp/Code/ImageMacro.xml M documentation-ui/src/main/resources/DocApp/Code/VersionMacro.xml A documentation-ui/src/test/java/org/xwiki/contrib/documentation/ui/DocumentationWikiMacrosPageTest.java Log Message: ----------- DA-117: Improve escaping of parameters in the Deprecated, Image and Version macros * Deprecated macro: escape the product, since and useInstead parameters for the xwiki/2.1 syntax, both in the badge text and in the (% %) parameters. * Image macro: escape the '~', '||' and ']]' sequences of the image reference, and escape the width (in the style parameter) and the caption for the xwiki/2.1 syntax. * Version macro: escape the product and the versions for the xwiki/2.1 syntax, both in the badge text and in the title and data-xwikiorg-* parameters. * Add the wiki macro store dependencies to the documentation-ui test dependencies. * Add DocumentationWikiMacrosPageTest, checking that special characters in the parameters are displayed as they are. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: 4f7755da84100eda10b0063edfa3d73b8f4ea390 https://github.com/xwiki-contrib/documentation/commit/4f7755da84100eda10b006... Author: Vincent Massol <[email protected]> Date: 2026-10-15 (Thu, 15 Oct 2026) Changed paths: M documentation-ui/src/main/resources/DocApp/Code/DocumentationSheet.xml M documentation-ui/src/main/resources/DocApp/Code/LandingPageSheet.xml A documentation-ui/src/test/java/org/xwiki/contrib/documentation/ui/DocumentationSearchFormPageTest.java Log Message: ----------- DA-118: Improve escaping in the documentation search forms * Escape the space name with $escapetool.xml in the f_space_prefix hidden input of the search forms of LandingPageSheet and DocumentationSheet. * Add DocumentationSearchFormPageTest, rendering both sheets for pages located in a space whose name holds special characters. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: 2aa76d3c0c86cc83af7c931a5eabb6ef364ab5a2 https://github.com/xwiki-contrib/documentation/commit/2aa76d3c0c86cc83af7c93... Author: Vincent Massol <[email protected]> Date: 2026-10-15 (Thu, 15 Oct 2026) Changed paths: M documentation-ui/src/main/resources/DocApp/Code/DocumentationNavigationPanel.xml A documentation-ui/src/test/java/org/xwiki/contrib/documentation/ui/DocumentationNavigationPanelPageTest.java A documentation-ui/src/test/java/org/xwiki/contrib/documentation/ui/TestDocumentTreeMacro.java A documentation-ui/src/test/java/org/xwiki/contrib/documentation/ui/TestDocumentTreeMacroParameters.java Log Message: ----------- DA-119: Improve escaping in the Documentation navigation panel * Escape the '~' and '"' characters of the root and exclusions parameter values of the documentTree macro call, as already done for the openTo parameter. * Add DocumentationNavigationPanelPageTest, rendering the panel content for a page located in a space whose name holds special characters, with a test replacement of the documentTree macro (TestDocumentTreeMacro) that displays the parameters it receives. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Compare: https://github.com/xwiki-contrib/documentation/compare/093399a8245b%5E...2aa... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/documentation/settings/notifications
participants (1)
-
XWiki Notifications