[xwiki/xwiki-platform] 29d6c6: XWIKI-23740: Improve the UI of Comments: Annotatio...
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 29d6c6a135300984c312932193dc2350a6cdf3a8 https://github.com/xwiki/xwiki-platform/commit/29d6c6a135300984c312932193dc2... Author: LucasC <[email protected]> Date: 2026-09-14 (Mon, 14 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-test/xwiki-platform-annotation-test-pageobjects/src/main/java/org/xwiki/annotation/test/po/AnnotationsLabel.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-test/xwiki-platform-annotation-test-pageobjects/src/main/java/org/xwiki/annotation/test/po/AnnotationsWindow.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-ui/src/main/resources/AnnotationCode/Macros.xml M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-ui/src/main/resources/AnnotationCode/Script.xml M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-ui/src/main/resources/AnnotationCode/Style.xml M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-ui/src/main/resources/AnnotationCode/Translations.xml M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-ui/src/test/java/org/xwiki/annotation/AnnotationCodeMacrosPageTest.java M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources.properties M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/BaseElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/PermalinkModal.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/viewers/comments.css M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/viewers/comments.js Log Message: ----------- XWIKI-23740: Improve the UI of Comments: Annotation look (#5928) * Redesign the annotation bubble markup/CSS to match the new Comments look * Implemented the share button * Add Docker tests for Share features * Fixed existing docker tests * Simplify page objects: extract shared ConfirmationBox helper * Fix stray :active box-shadow on annotation bubble buttons * Fix BaseElement#confirmAction() CSS selector mismatch * Use $annotationClassDocName instead of hardcoded XWiki.XWikiComments in thread-view/delete queries * Forward the "view thread" click to the thread-toggle in the Comments tab * Used a <time> element for the annotation date * Built the edit action's query string with $escapetool.url() instead of manual concatenation * Used let and native DOM APIs instead of var and Prototype.js in the thread-toggle wiring * Used the Clipboard API for the permalink copy button, with a checked execCommand fallback * Converted the delete action from a link to a real POST form * Renamed hoverOnAnnotationById/ByText to openAnnotationViewById/ByText * Made the delete click handler support both the POST-form and plain-link markup * Skipped the Edit/Delete check in 'create' mode, since $ann.id doesn't exist yet * Updated the delete test selector to match both markups * Escaped the delete form's action URL and button title * Used const/item.closest('form') instead of var/item.up('form') in the delete click handler * Used const and function declarations instead of var in the permalink copy handler * Fixed the toolbox crashing when $xcontext.doc isn't bound, by computing $annHasComment locally and using $annoDoc instead of $doc * Fixed AnnotationCodeMacrosPageTest to match (selector, rights mocks, expected URL) * Used querySelector/addEventListener instead of Prototype's down/observe in fillEditForm, fillViewPanel and fillCreateForm * Fixed the bubble's reply button forwarding, which still looked for the old a.reply class instead of a.commentreply * Removed the dead container.stopObserving('mouseout') call, nothing in the module registers a mouseout listener on that element anymore * Fixed the form-based delete navigating away and reloading the page instead of updating in place, by submitting it through ConfirmedAjaxRequest (like the link-based delete) instead of a native form submit To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications