[xwiki/xwiki-platform] 90703b: [XWIKI] Fix SonarQube S2387: Rename RightMap.keySe...
Branch: refs/heads/claude/focused-carson-LadW1 Home: https://github.com/xwiki/xwiki-platform Commit: 90703b6319257396dac9ab4f62316aaf163e2865 https://github.com/xwiki/xwiki-platform/commit/90703b6319257396dac9ab4f62316... Author: Claude <[email protected]> Date: 2026-05-12 (Tue, 12 May 2026) Changed paths: M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/RightMap.java Log Message: ----------- [XWIKI] Fix SonarQube S2387: Rename RightMap.keySet field to avoid shadowing AbstractMap.keySet The private field 'keySet' in RightMap was shadowing the 'keySet' field in its parent class AbstractMap, which is flagged by SonarQube rule S2387 as a BLOCKER issue. Renamed the field to 'cachedKeySet' to clarify its purpose as a cached value and eliminate the shadowing. https://claude.ai/code/session_012AtaFRwNqcM6w4eFRtvn2v Commit: 9682012b67c7fea83aa888cd5c6367f12d66e79c https://github.com/xwiki/xwiki-platform/commit/9682012b67c7fea83aa888cd5c636... Author: Claude <[email protected]> Date: 2026-05-12 (Tue, 12 May 2026) Changed paths: M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggest.js Log Message: ----------- [XWIKI] Fix SonarQube S3516: getSuggestions should not always return the same value The getSuggestions function in suggest.js was always returning false regardless of what action was taken. SonarQube rule S3516 flags this as a BLOCKER since a function that always returns the same value usually indicates a bug. Returned true when a new AJAX request is scheduled (the else branch), keeping false for all other cases where no new request is made (input unchanged, too short, or served from cache). https://claude.ai/code/session_012AtaFRwNqcM6w4eFRtvn2v Compare: https://github.com/xwiki/xwiki-platform/compare/90703b631925%5E...9682012b67... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications