[xwiki/xwiki-platform] a160aa: [Misc] Convert tests to JUnit5 + cleanup tests
Branch: refs/heads/stable-16.10.x Home: https://github.com/xwiki/xwiki-platform Commit: a160aa9616cd4fc6310af3af20e144f5b9376d98 https://github.com/xwiki/xwiki-platform/commit/a160aa9616cd4fc6310af3af20e14... Author: Vincent Massol <[email protected]> Date: 2026-09-09 (Wed, 09 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/AbstractNotifyOnUpdateListTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCacheConfigurationTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/event/CommentEventGeneratorListenerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/event/XClassPropertyEventGeneratorListenerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/event/XObjectEventGeneratorListenerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/filter/XWikiDocumentFilterUtilsTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CompactStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CompactWikiStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentAttachmentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentUserAndGroupDocumentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/UserAndGroupDocumentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/XClassRelativeStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/DefaultDBListQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/ViewableAllowedDBListValueFilterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/pdf/XHTML2FOTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/plugin/rightsmanager/ReferenceUserIteratorTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/query/CurrentLanguageQueryFilterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/render/OldRenderingProviderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/sheet/ClassSheetBinderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/xml/DOMXMLWriterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/xml/XMLAttributeValueFilterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/BaseObjectReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/BooleanClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/DBTreeListClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/DateClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/NumberClassTest.java Log Message: ----------- [Misc] Convert tests to JUnit5 + cleanup tests (cherry picked from commit ce3d787b03a084c22efecfbdb48a46c1d9c25f3c) Commit: a6ed3b4b67af27be3aa6cbd3fac1dd2334225b67 https://github.com/xwiki/xwiki-platform/commit/a6ed3b4b67af27be3aa6cbd3fac1d... Author: Michael Hamann <[email protected]> Date: 2026-09-09 (Wed, 09 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/BooleanClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/ComputedFieldClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/DBTreeListClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/PropertyClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/BooleanClassTest.java A xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/ComputedFieldClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/DBTreeListClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/PropertyClassTest.java Log Message: ----------- XWIKI-24750: Escaping of property values is inconsistent * Consistently escape all values and attributes to ensure consistent and correct behavior. This adds escaping even in cases where either the displayed values don't need escaping or there are no attributes to escape to ensure that anything added in the future won't miss it. * Add escaping tests. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> (cherry picked from commit 75afa4d040a9749e8b11de88d6d52de8988dcb08) Commit: 3016eb2879b33bc0badf353b27fb1ced2b0cd7e8 https://github.com/xwiki/xwiki-platform/commit/3016eb2879b33bc0badf353b27fb1... Author: Michael Hamann <[email protected]> Date: 2026-09-09 (Wed, 09 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java Log Message: ----------- [Misc] Fix the null dereferences in BaseCollection#getDiff() lost when backporting #6299 * The backport of "[Misc] Fix three SonarQube javabugs:S2259 null dereferences in oldcore" (#6299, 703af2d9451) brought its BaseCollectionTest additions but not its BaseCollection change, so both new tests have been failing on this branch: getDiff() dereferences the new property in the added, changed and plain-value branches although its own comparison right above them explicitly allows that property to be null. * Apply the same fix, adapted to this branch where the computation is still inlined in getDiff() instead of the addPropertyAddedDiff()/addPropertyChangedDiff() methods master extracted since: add getPropertyDisplayValue() with the same null handling as master's and report a missing property as an empty value, which is how that comparison already treats it. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Compare: https://github.com/xwiki/xwiki-platform/compare/e7ae3f5ba977...3016eb2879b3 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications