[xwiki-contrib/application-releasenotes] 82f544: RN-131: A script can create a change for a release...
Branch: refs/heads/master Home: https://github.com/xwiki-contrib/application-releasenotes Commit: 82f5442afe7dc08d3515e36c360549d054761729 https://github.com/xwiki-contrib/application-releasenotes/commit/82f5442afe7... Author: Vincent Massol <[email protected]> Date: 2026-10-11 (Sun, 11 Oct 2026) Changed paths: M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/EntryPageAllocator.java A application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesCaller.java A application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesEntryPoint.java M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesReferences.java M application-releasenotes-api/src/main/java/org/xwiki/contrib/releasenotes/script/ReleaseNotesScriptService.java M application-releasenotes-api/src/main/resources/META-INF/components.txt M application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/internal/DefaultChangeManagerTest.java M application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/internal/DefaultReleaseNoteManagerTest.java A application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/internal/ReleaseNotesEntryPointTest.java M application-releasenotes-api/src/test/java/org/xwiki/contrib/releasenotes/script/ReleaseNotesScriptServiceTest.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/AbstractReleaseNotesResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangeResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangesResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNoteResource.java M application-releasenotes-rest/src/main/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNotesResource.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangeResourceTest.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultChangesResourceTest.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNoteResourceTest.java M application-releasenotes-rest/src/test/java/org/xwiki/contrib/releasenotes/rest/internal/DefaultReleaseNotesResourceTest.java M application-releasenotes-ui/src/test/java/org/xwiki/contrib/releasenotes/ReleaseNotesApiComponentList.java Log Message: ----------- RN-131: A script can create a change for a release note that does not exist (#70) * New internal ReleaseNotesEntryPoint: the one place a script call or a REST request goes through to reach the managers; it locates the page, checks the rights of a ReleaseNotesCaller (current user, plus the script author for a script), checks that a change goes to an existing release note, then calls the manager * The script service and the REST resources only translate their input into an entry-point call; the managers still check no right * The script service now refuses a change for a missing release note, as REST did (ReleaseNotesNotFoundException, a 404 over REST) * Everything else a script or a REST client can observe is unchanged: same status codes and messages, same order of the checks (REST still validates a posted release note before the rights check, and checks the rights and the release note before reading a posted change) * Entry page references are built by ReleaseNotesReferences.entry, shared by EntryPageAllocator and the REST change resource * Fix two test comments that still said the managers check rights Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...
participants (1)
-
XWiki Notifications