Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-rendering Commit: 3627a307a059cacafa6a286fbe96ca0ab39af11b https://github.com/xwiki/xwiki-rendering/commit/3627a307a059cacafa6a286fbe96... Author: Vincent Massol <[email protected]> Date: 2026-08-27 (Thu, 27 Aug 2026) Changed paths: M .github/workflows/sonar-pr.yml Log Message: ----------- [Misc] Cover the legacy modules in the SonarCloud pull request analysis * Activate the legacy profile, so that the -legacy modules are part of the reactor this job builds. The master analysis covers them, ci.xwiki.org running its quality build with that profile, so a pull request adding an issue to one of them used to pass the gate and turn master red afterwards. * Derive the modules to select from the reactor Maven itself builds, reading the poms as XML and for the profiles the build activates, rather than scanning their text: a pom holds <profiles> and <module> elements inside comments, which the text scan took for real ones, and a module declared as a nested or a relative path was not resolved at all. * Stop widening to the whole reactor when the changed aggregator pom belongs to no module of that reactor, such as the pom of a functional test module, of a distribution module or of a project a module ships under src/it. Such a pom drives nothing this job analyzes. * Read the changed paths with git diff -z, so that a path git would otherwise quote, and which no walk up the directories then resolves, is not dropped without a word. * Widen to the whole reactor when a changed file belongs to a module declared by a profile Maven activates on its own, since whether the reactor holds it is exactly what cannot be decided here. * Take the profiles from a single job level variable, so that the reactor the selection reasons about cannot drift from the reactor the build and the analysis use. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications